Re: [PATCH 1/2]MSI(X) save/restore for suspend/resume

[Matthew Wilcox <matthew@wil.cx>]

On Wed, Jan 11, 2006 at 04:18:22PM +0800, Shaohua Li wrote:
> +static inline void pci_remove_saved_cap(struct pci_dev *pci_dev,
> +	struct pci_cap_saved_state *cap)
> +{
> +	struct pci_cap_saved_state *last;
> +	last = pci_dev->saved_cap_space;
> +	if (!last)
> +		return;
> +
> +	if (last == cap) {
> +		pci_dev->saved_cap_space = last->next;
> +		return;
> +	}
> +	while (last->next && last->next != cap)
> +		last = last->next;
> +	if (last->next)
> +		last->next = last->next->next;
> +}

I believe the more standard way of doing a singly-linked-list
delete looks like this:

{
        struct pci_cap_saved_state **lastp = &pci_dev->saved_cap_space;

        while (*lastp && *lastp != cap)
                lastp = &(*lastp)->next;
        if (*lastp)
                *lastp = (*lastp)->next;
}

untested, of course.