From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
ak@suse.de, linux-kernel@vger.kernel.org, sct@redhat.com,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: 2.6.15-git7 oopses in ext3 during LTP runs
Date: Wed, 11 Jan 2006 23:19:42 +0100 [thread overview]
Message-ID: <20060111221942.GA17231@elte.hu> (raw)
In-Reply-To: <1137014875.2929.81.camel@laptopd505.fenrus.org>
* Arjan van de Ven <arjan@infradead.org> wrote:
> > We expect the lock to be held on entry. Hence we expect mutex_trylock()
> > to return zero.
>
> you are correct, and the x86-64 mutex.h is buggy
ahh ... indeed! And i386 trylock was buggy too.
Ingo
----
fix typo in asm-i386/mutex.h:__mutex_fastpath_trylock - noticed by
Arjan van de Ven.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
--- include/asm-i386/mutex.h.orig
+++ include/asm-i386/mutex.h
@@ -125,7 +125,7 @@ __mutex_fastpath_trylock(atomic_t *count
* the mutex state would be.
*/
#ifdef __HAVE_ARCH_CMPXCHG
- if (likely(atomic_cmpxchg(count, 1, 0)) == 1)
+ if (likely(atomic_cmpxchg(count, 1, 0) == 1))
return 1;
return 0;
#else
next prev parent reply other threads:[~2006-01-11 22:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-11 20:26 2.6.15-git7 oopses in ext3 during LTP runs Andi Kleen
2006-01-11 20:46 ` Andrew Morton
2006-01-11 20:55 ` Arjan van de Ven
2006-01-11 21:07 ` Andrew Morton
2006-01-11 21:27 ` Arjan van de Ven
2006-01-11 22:19 ` Ingo Molnar [this message]
2006-01-11 22:40 ` Pavel Machek
2006-01-11 22:44 ` David S. Miller
2006-01-12 0:30 ` Ingo Molnar
2006-01-11 22:47 ` Jesper Juhl
2006-01-12 8:51 ` Pavel Machek
2006-01-12 0:55 ` 2.6.15-git7 oopses in ext3 during LTP runs II - more problems Andi Kleen
2006-01-12 1:14 ` Andrew Morton
2006-01-12 1:25 ` Andi Kleen
2006-01-11 21:25 ` 2.6.15-git7 oopses in ext3 during LTP runs Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060111221942.GA17231@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox