public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: dtor_core@ameritech.net
Cc: Patrick Read <pread99999@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: Oops in Kernel 2.6.15 usbhid
Date: Thu, 12 Jan 2006 02:11:25 +0100	[thread overview]
Message-ID: <20060112011125.GO29663@stusta.de> (raw)
In-Reply-To: <d120d5000601110631j6705c71cya5faf293cac148a6@mail.gmail.com>

On Wed, Jan 11, 2006 at 09:31:32AM -0500, Dmitry Torokhov wrote:
> On 1/11/06, Patrick Read <pread99999@gmail.com> wrote:
> > On 1/9/06, Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> > > ===================================================================
> > > --- work.orig/drivers/usb/input/pid.c
> > > +++ work/drivers/usb/input/pid.c
> > > @@ -259,7 +259,7 @@ static int hid_pid_upload_effect(struct
> > >  int hid_pid_init(struct hid_device *hid)
> > >  {
> > >         struct hid_ff_pid *private;
> > > -       struct hid_input *hidinput = list_entry(&hid->inputs, struct hid_input, list);
> > > +       struct hid_input *hidinput = list_entry(hid->inputs.next, struct hid_input, list);
> > >         struct input_dev *input_dev = hidinput->input;
> > >
> > >         private = hid->ff_private = kzalloc(sizeof(struct hid_ff_pid), GFP_KERNEL);
> > >
> >
> > The above fix works like a charm.  2.6.15 is running on this very
> > computer that I'm typing on.
> >
> > Thank you for your good work.  Please ensure that this fix gets
> > incorporated in the mainline kernel.
> >
> 
> Thank you for testing it, I will forward it to Linus.

Could you also forward it stable@kernel.org for inclusion in 2.6.15.x?

> Dmitry

TIA
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2006-01-12  1:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-06  6:25 PROBLEM: Oops in Kernel 2.6.15 usbhid Patrick Read
2006-01-10  5:54 ` Dmitry Torokhov
2006-01-11  8:21   ` Patrick Read
2006-01-11 14:31     ` Dmitry Torokhov
2006-01-12  1:11       ` Adrian Bunk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-01-13 18:51 Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060112011125.GO29663@stusta.de \
    --to=bunk@stusta.de \
    --cc=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pread99999@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox