From: Andi Kleen <ak@suse.de>
To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: akpm@osdl.org, rdreier@cisco.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2 of 2] __raw_memcpy_toio32 for x86_64
Date: Thu, 12 Jan 2006 02:33:51 +0100 [thread overview]
Message-ID: <200601120233.51601.ak@suse.de> (raw)
In-Reply-To: <1137029233.17705.46.camel@localhost.localdomain>
On Thursday 12 January 2006 02:27, Bryan O'Sullivan wrote:
> > > +__raw_memcpy_toio32:
> > > + movl %edx,%ecx
> > > + shrl $1,%ecx
> >
> > 1? If it's called memcpy it should get a byte argument, no? If not
> > name it something else, otherwise everybody will be confused.
>
> It's called toio32 for a reason :-)
>
> Also, the kernel doc clearly states its purpose.
I think it's deeply wrong to reuse names of standard functions with different
arguments. Either pass bytes or give it some other name.
> > movsq? I thought you wanted 32bit IO?
>
> The northbridge will split qword writes into pairs of dword writes.
That sounds like a very chipset specific assumption. Is that safe
to make? If yes you would need to document it clearly. But most likely
it's not a good idea to do this. Even if it works right now it would
be another death trap for the next user.
-Andi
next prev parent reply other threads:[~2006-01-12 1:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 0:29 [PATCH 0 of 2] Much smaller MMIO copy patches Bryan O'Sullivan
2006-01-12 0:29 ` [PATCH 1 of 2] Introduce __raw_memcpy_toio32 Bryan O'Sullivan
2006-01-12 0:29 ` [PATCH 2 of 2] __raw_memcpy_toio32 for x86_64 Bryan O'Sullivan
2006-01-12 0:56 ` Andi Kleen
2006-01-12 1:21 ` Roland Dreier
2006-01-12 1:27 ` Andi Kleen
2006-01-12 1:32 ` Roland Dreier
2006-01-12 1:40 ` Andi Kleen
2006-01-12 1:27 ` Bryan O'Sullivan
2006-01-12 1:33 ` Andi Kleen [this message]
2006-01-12 4:14 ` Bryan O'Sullivan
2006-01-12 4:19 ` Andi Kleen
2006-01-12 4:32 ` Bryan O'Sullivan
2006-01-12 4:45 ` Andi Kleen
2006-01-12 5:04 ` Bryan O'Sullivan
2006-01-12 15:54 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601120233.51601.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=bos@pathscale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox