From: Jens Axboe <axboe@suse.de>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] Mask capabilities for SCSI-1 CD drive
Date: Thu, 12 Jan 2006 08:41:02 +0100 [thread overview]
Message-ID: <20060112074102.GC17718@suse.de> (raw)
In-Reply-To: <200601112359_MC3-1-B5B7-409F@compuserve.com>
On Wed, Jan 11 2006, Chuck Ebbert wrote:
> SCSI-1 CD drives can't do MRW or be opened for writing, so mask off
> those capabilities.
>
> Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
>
> --- 2.6.15a.orig/drivers/scsi/sr.c
> +++ 2.6.15a/drivers/scsi/sr.c
> @@ -762,8 +762,9 @@ static void get_capabilities(struct scsi
> /* failed, drive doesn't have capabilities mode page */
> cd->cdi.speed = 1;
> cd->cdi.mask |= (CDC_CD_R | CDC_CD_RW | CDC_DVD_R |
> - CDC_DVD | CDC_DVD_RAM |
> - CDC_SELECT_DISC | CDC_SELECT_SPEED);
> + CDC_DVD | CDC_DVD_RAM |
> + CDC_SELECT_DISC | CDC_SELECT_SPEED |
> + CDC_MRW | CDC_MRW_W | CDC_RAM);
> kfree(buffer);
> printk("%s: scsi-1 drive\n", cd->cdi.name);
> return;
Looks fine, thanks.
Acked-by: Jens Axboe <axboe@suse.de>
--
Jens Axboe
prev parent reply other threads:[~2006-01-12 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 4:58 [patch] Mask capabilities for SCSI-1 CD drive Chuck Ebbert
2006-01-12 7:41 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060112074102.GC17718@suse.de \
--to=axboe@suse.de \
--cc=76306.1226@compuserve.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox