Re: [PATCH] Prevent trident driver from grabbing pcnet32 hardware

Jon Mason
2006-01-12T22:20:48Z

On Thu, Jan 12, 2006 at 11:00:39PM +0100, Adrian Bunk wrote:
> On Thu, Jan 12, 2006 at 03:47:19PM -0600, Jon Mason wrote:
> > On Thu, Jan 12, 2006 at 10:07:35PM +0200, Muli Ben-Yehuda wrote:
> > > On Thu, Jan 12, 2006 at 08:28:30PM +0100, Jiri Slaby wrote:
> > >
> > > > You should change alsa driver (sound/pci/trident/trident.c), rather than this,
> > > > which will be removed soon, I guess. And, additionally, could you change that
> > > > lines to use PCI_DEVICE macro?
> > >
> > > This driver is not up for removal soon, as it supports a device that
> > > the alsa driver apparently doesn't (the INTERG_5050). As for
> > > PCI_DEVICE, agreed. Jon, feel like patching it up?
> >
> > Patches to follow.
> >
> > After looking at the ALSA driver, it doesn't support PCI IDs for
> > ALI_5451 or CYBER5050. Someone should look into porting any necessary
> > code from sound/oss/trident.c to sound/pci/trident/trident.c
>
> CYBER5050 is discussed in ALSA bug #1293 (tester wanted).
> ALI_5451 is supported by the snd-ali5451 driver.

Sorry, I grepped for PCI_DEVICE_ID_ALI_5451 not 0x5451. Sending a patch
to fix that up too.

Thanks,
Jon