Re: [PATCH] Prevent trident driver from grabbing pcnet32 hardware

Jiri Slaby
2006-01-12T19:28:36Z

Jon Mason napsal(a):
> Some pcnet32 hardware erroneously has the Vendor ID for Trident. The
> pcnet32 driver looks for the PCI ethernet class before grabbing the
> hardware, but the current trident driver does not check against the
> PCI audio class. This allows the trident driver to claim the pcnet32
> hardware. This patch prevents that.
>
> This patch is untested on Trident 4DWAVE_DX hardware, but has been
> tested on pcnet32 hardware.
>
> Thanks,
> Jon
>
> Signed-off-by: Jon Mason <jdmason@us.ibm.com>
>
> diff -r 4a7597b41d25 sound/oss/trident.c
> --- a/sound/oss/trident.c Wed Jan 11 19:14:08 2006
> +++ b/sound/oss/trident.c Thu Jan 12 11:32:26 2006
You should change alsa driver (sound/pci/trident/trident.c), rather than this,
which will be removed soon, I guess. And, additionally, could you change that
lines to use PCI_DEVICE macro?

regards,
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ jirislaby@gmail.com ~\-/~
B67499670407CE62ACC8 22A032CC55C339D47A7E