Re: [PATCH] Prevent trident driver from grabbing pcnet32 hardware

Jon Mason
2006-01-12T22:11:19Z

On Thu, Jan 12, 2006 at 05:06:53PM -0500, Lee Revell wrote:
> On Thu, 2006-01-12 at 22:58 +0100, Adrian Bunk wrote:
> > On Thu, Jan 12, 2006 at 04:15:38PM -0500, Lee Revell wrote:
> > > On Thu, 2006-01-12 at 22:07 +0200, Muli Ben-Yehuda wrote:
> > > > On Thu, Jan 12, 2006 at 08:28:30PM +0100, Jiri Slaby wrote:
> > > >
> > > > > You should change alsa driver (sound/pci/trident/trident.c), rather than this,
> > > > > which will be removed soon, I guess. And, additionally, could you change that
> > > > > lines to use PCI_DEVICE macro?
> > > >
> > > > This driver is not up for removal soon, as it supports a device that
> > > > the alsa driver apparently doesn't (the INTERG_5050).
> > >
> > > When were you going to report this?
> >
> > I already reported this as ALSA bug #1293.
> >
> > The problem is the lack of a tester, and I'm currently inclined to
> > schedule this driver for removal although this PCI ID is still missing -
> > either noone is using these settop boxes anymore or someone will
> > volunteer to test patches.
>
> Hmm, yeah, if the hardware was only used in set top boxes there's not a
> lot that can be done, unless someone wants to donate one to the ALSA
> project.
>
> It might be as simple as adding the PCI IDs to the driver.

I agree, add the IDs to the ALSA driver and if someone using a
INTERG_5050 adapter has problems....instant tester.