Re: [PATCH 2.6.15] ia64: use i386 dmi_scan.c

Bjorn Helgaas
2006-01-18T17:29:54Z

On Tuesday 17 January 2006 17:17, Bjorn Helgaas wrote:
>> But it's a start, and maybe the consolidation could be done later.
>
> Index: work-mm3/arch/i386/kernel/dmi_scan.c
> ===================================================================
> --- work-mm3.orig/arch/i386/kernel/dmi_scan.c 2006-01-17 15:18:42.000000000 -0700
> +++ work-mm3/arch/i386/kernel/dmi_scan.c 2006-01-17 16:58:11.000000000 -0700
> @@ -39,9 +39,18 @@
> void (*decode)(struct dmi_header *))
> {
> u8 *buf, *data;
> - int i = 0;
> + int iomem = 1, i = 0;
>
> - buf = dmi_ioremap(base, len);
> + if (efi_enabled) {
> + if (efi_mem_attributes(base & EFI_MEMORY_WB)) {

Ouch, ignore this patch if you haven't already. The above is
parenthesized wrong.

Matt, what's your opinion on proceeding? I know you want to get
the DMI stuff in distros. I'm looking at reworking ioremap to
hide all this stuff, but that'll be a bigger change and may be
harder to get into distro releases.

For upstream, the ioremap rework sounds like the way to go, but
I don't know which the distros would prefer for updates.