From: Al Viro <viro@ftp.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: "P. Christeas" <p_christ@hol.gr>,
hch@lst.de, linux-kernel@vger.kernel.org, raven@themaw.net
Subject: Re: Regression in Autofs, 2.6.15-git
Date: Sat, 14 Jan 2006 14:01:22 +0000 [thread overview]
Message-ID: <20060114140122.GK27946@ftp.linux.org.uk> (raw)
In-Reply-To: <20060114051737.6e49dffe.akpm@osdl.org>
On Sat, Jan 14, 2006 at 05:17:37AM -0800, Andrew Morton wrote:
> You oopsed accessing 0x00000030, and offsetof(super_block, s_flags) is
> 0x30. So autofs4 has passed in a dentry which has a NULL
> dentry->d_inode->i_sb and the new code didn't expect that.
It's not just new code... inode->i_sb should _never_ be NULL, period.
We set it immediately after memory had been allocated by alloc_inode()
and never modify afterwards, let alone reset to NULL.
next prev parent reply other threads:[~2006-01-14 14:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-14 0:17 Regression in Autofs, 2.6.15-git P. Christeas
2006-01-14 11:34 ` Andrew Morton
2006-01-14 11:50 ` P. Christeas
2006-01-14 11:54 ` Andrew Morton
2006-01-14 12:56 ` P. Christeas
2006-01-14 13:17 ` Andrew Morton
2006-01-14 14:01 ` Al Viro [this message]
2006-01-14 14:05 ` P. Christeas
2006-01-14 14:28 ` Ian Kent
2006-01-14 15:11 ` P. Christeas
2006-01-14 15:25 ` P. Christeas
2006-01-14 17:06 ` Ian Kent
2006-01-14 17:54 ` P. Christeas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060114140122.GK27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=p_christ@hol.gr \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox