From: Jean Delvare <khali@linux-fr.org>
To: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
Cc: LKML <linux-kernel@vger.kernel.org>,
video4linux-list@redhat.com,
Russell King <rmk+kernel@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH] Fix warning in dvb-btxx driver
Date: Sun, 15 Jan 2006 21:26:37 +0100 [thread overview]
Message-ID: <20060115212637.23fda216.khali@linux-fr.org> (raw)
Hi Mauro, all,
Fix the following warning I am seeing in 2.6.15-git11, which seems
to have been introduced by commit 348290a4ae143a692124330942b464ccdb0d0365:
CC [M] drivers/media/dvb/bt8xx/dvb-bt8xx.o
drivers/media/dvb/bt8xx/dvb-bt8xx.c:923: warning: initialization from incompatible pointer type
It would have also been possible to keep "void" as the return type and
change the function itself instead, but given that the driver core's
.remove method returns an int, my guess is that we want the same here.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
drivers/media/video/bttv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.15-git.orig/drivers/media/video/bttv.h 2006-01-15 10:49:37.000000000 +0100
+++ linux-2.6.15-git/drivers/media/video/bttv.h 2006-01-15 20:47:24.000000000 +0100
@@ -366,7 +366,7 @@
struct device_driver drv;
char wanted[BUS_ID_SIZE];
int (*probe)(struct bttv_sub_device *sub);
- void (*remove)(struct bttv_sub_device *sub);
+ int (*remove)(struct bttv_sub_device *sub);
void (*gpio_irq)(struct bttv_sub_device *sub);
};
#define to_bttv_sub_drv(x) container_of((x), struct bttv_sub_driver, drv)
--
Jean Delvare
reply other threads:[~2006-01-15 20:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060115212637.23fda216.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@brturbo.com.br \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox