From: mita@miraclelinux.com (Akinobu Mita)
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] changes about Call Trace:
Date: Mon, 16 Jan 2006 22:42:04 +0900 [thread overview]
Message-ID: <20060116134204.GC6707@miraclelinux.com> (raw)
In-Reply-To: <20060116134109.GA6707@miraclelinux.com>
remove symbolsize, and change offset format from hexadecimal to
decimal in print_symbol()
Signed-off-by: Akinobu Mita <mita@miraclelinux.com>
--- 2.6-git/kernel/kallsyms.c.orig 2006-01-16 22:06:16.000000000 +0900
+++ 2.6-git/kernel/kallsyms.c 2006-01-16 22:09:52.000000000 +0900
@@ -237,7 +237,7 @@ int __print_symbol(const char *fmt, unsi
const char *name;
unsigned long offset, size;
char namebuf[KSYM_NAME_LEN+1];
- char buffer[sizeof("%s+%#lx/%#lx [%s]") + KSYM_NAME_LEN +
+ char buffer[sizeof("%s+%ld [%s]") + KSYM_NAME_LEN +
2*(BITS_PER_LONG*3/10) + MODULE_NAME_LEN + 1];
name = kallsyms_lookup(address, &size, &offset, &modname, namebuf);
@@ -246,10 +246,9 @@ int __print_symbol(const char *fmt, unsi
sprintf(buffer, "0x%lx", address);
else {
if (modname)
- sprintf(buffer, "%s+%#lx/%#lx [%s]", name, offset,
- size, modname);
+ sprintf(buffer, "%s+%ld [%s]", name, offset, modname);
else
- sprintf(buffer, "%s+%#lx/%#lx", name, offset, size);
+ sprintf(buffer, "%s+%ld", name, offset);
}
return printk(fmt, buffer);
}
next prev parent reply other threads:[~2006-01-16 13:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-16 12:16 [PATCH 0/3] changes about Call Trace: Akinobu Mita
2006-01-16 12:17 ` [PATCH 1/3] makes print_symbol() return int Akinobu Mita
2006-01-16 14:16 ` Jesper Juhl
2006-01-16 14:24 ` Akinobu Mita
2006-01-16 15:18 ` Jesper Juhl
2006-01-16 12:18 ` [PATCH 2/3] use usual call trace format on x86-64 Akinobu Mita
2006-01-16 12:22 ` Andi Kleen
2006-01-16 12:32 ` Christoph Hellwig
2006-01-16 12:46 ` Andi Kleen
2006-01-16 12:18 ` [PATCH 3/3] omit symbol size field in print_symbol() Akinobu Mita
2006-01-16 12:22 ` Andi Kleen
2006-01-16 14:37 ` Arjan van de Ven
2006-01-16 15:51 ` Akinobu Mita
2006-01-17 7:06 ` Akinobu Mita
2006-01-16 12:22 ` [PATCH 0/3] changes about Call Trace: Andi Kleen
2006-01-16 13:41 ` Akinobu Mita
2006-01-16 13:41 ` Akinobu Mita
2006-01-16 13:42 ` Akinobu Mita [this message]
2006-01-16 22:22 ` Andi Kleen
2006-01-17 16:53 ` Jan Engelhardt
2006-01-17 7:05 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060116134204.GC6707@miraclelinux.com \
--to=mita@miraclelinux.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox