From: Jens Axboe <axboe@suse.de>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Alejandro Bonilla Beeche <abonilla@linuxwireless.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
torvalds@osdl.org, hch@infradead.org
Subject: Re: drivers/block/ps2esdi.c
Date: Tue, 17 Jan 2006 00:23:49 +0100 [thread overview]
Message-ID: <20060116232349.GX3945@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0601161329000.24990@shark.he.net>
On Mon, Jan 16 2006, Randy.Dunlap wrote:
> On Mon, 16 Jan 2006, Alejandro Bonilla Beeche wrote:
>
> > It looks like the Linux-2.6 tree is still broken...
> >
> > Just FYI
> >
> >
> > CC drivers/block/loop.o
> > CC drivers/block/ps2esdi.o
> > In file included from drivers/block/ps2esdi.c:42:
> > include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy - please
> > move your driver to the new sysfs api"
> > drivers/block/ps2esdi.c: In function 'ps2esdi_getgeo':
> > drivers/block/ps2esdi.c:1064: error: dereferencing pointer to incomplete
> > type
> > drivers/block/ps2esdi.c:1065: error: dereferencing pointer to incomplete
> > type
> > drivers/block/ps2esdi.c:1066: error: dereferencing pointer to incomplete
> > type
> > make[3]: *** [drivers/block/ps2esdi.o] Error 1
> > make[2]: *** [drivers/block] Error 2
> > make[1]: *** [drivers] Error 2
> > make[1]: Leaving directory `/root/linux-2.6'
> > make: *** [debian/stamp-build-kernel] Error 2
> > debian:~/linux-2.6#
>
> As Adrian (IIRC) pointed out last time this was posted (last week),
> this is what you can get when you enable "BROKEN". IOW, see
> drivers/block/Kconfig:
>
> config BLK_DEV_PS2
> tristate "PS/2 ESDI hard disk support"
> depends on MCA && MCA_LEGACY && BROKEN
> ^^^^^^
>
> so please send patches to fix it (the driver) if you care about it.
Well this breakage is new though, Christoph looks like fallout from the
geo stuff.
diff --git a/drivers/block/ps2esdi.c b/drivers/block/ps2esdi.c
index 43415f6..bea75f2 100644
--- a/drivers/block/ps2esdi.c
+++ b/drivers/block/ps2esdi.c
@@ -43,6 +43,7 @@
#include <linux/init.h>
#include <linux/ioport.h>
#include <linux/module.h>
+#include <linux/hdreg.h>
#include <asm/system.h>
#include <asm/io.h>
--
Jens Axboe
next prev parent reply other threads:[~2006-01-16 23:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-16 21:26 drivers/block/ps2esdi.c Alejandro Bonilla Beeche
2006-01-16 21:30 ` drivers/block/ps2esdi.c Randy.Dunlap
2006-01-16 23:23 ` Jens Axboe [this message]
2006-01-16 23:24 ` drivers/block/ps2esdi.c Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060116232349.GX3945@suse.de \
--to=axboe@suse.de \
--cc=abonilla@linuxwireless.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox