From: Tony Lindgren <tony@atomide.com>
To: Kumar Gala <galak@gate.crashing.org>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Kumar Gala <galak@kernel.crashing.org>,
Dmitry Torokhov <dtor_core@ameritech.net>,
Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [patch 6/6] serial8250: convert to the new platform device interface
Date: Mon, 16 Jan 2006 18:35:24 -0800 [thread overview]
Message-ID: <20060117023524.GQ4511@atomide.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0601161752560.6677-100000@gate.crashing.org>
* Kumar Gala <galak@gate.crashing.org> [060116 16:02]:
> On Mon, 16 Jan 2006, Russell King wrote:
>
> > On Mon, Jan 16, 2006 at 04:27:17PM -0600, Kumar Gala wrote:
> > > This patch is breaking arch/ppc & arch/powerpc usage of 8250.c. The
> > > issue appears to be with the order in which platform_driver_register
> > > () is called vs platform_device_add().
> > >
> > > arch/powerpc/kernel/legacy_serial.c registers an 8250 device on the
> > > platform bus before 8250_init() gets called.
> > >
> > > Changing the order of platform_driver_register() vs
> > > platform_device_add() fixes the issue. I'm still not sure what the
> > > correct solution to this is. Ideas? comments?
> >
> > Mea Culpa - should've spotted that - that patch is actually rather
> > broken. platform_driver_register() can't be moved from where it
> > initially was.
>
> This seems to fix my issue on arch/powerpc and arch/ppc, please push to
> Linus ASAP.
This patch fixes problems on omap too.
Tony
next prev parent reply other threads:[~2006-01-17 2:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-11 6:47 [patch 0/6] Assorted conversions to the new platform device interface Dmitry Torokhov
2006-01-11 6:47 ` [patch 1/6] hdaps: convert " Dmitry Torokhov
2006-01-11 6:47 ` [patch 2/6] vr41xx: " Dmitry Torokhov
2006-01-11 6:47 ` [patch 3/6] mv64x600_wdt: " Dmitry Torokhov
2006-01-11 6:47 ` [patch 4/6] tb0219: " Dmitry Torokhov
2006-01-11 6:47 ` [patch 5/6] dcdbas: " Dmitry Torokhov
2006-01-11 6:47 ` [patch 6/6] serial8250: " Dmitry Torokhov
2006-01-16 22:27 ` Kumar Gala
2006-01-16 23:31 ` Russell King
2006-01-16 23:54 ` Kumar Gala
2006-01-17 2:35 ` Tony Lindgren [this message]
2006-01-17 19:36 ` Olaf Hering
2006-01-18 9:56 ` Russell King
2006-01-18 10:10 ` Olaf Hering
2006-01-18 11:03 ` Olaf Hering
2006-01-17 21:41 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060117023524.GQ4511@atomide.com \
--to=tony@atomide.com \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=galak@gate.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox