From: Christoph Hellwig <hch@infradead.org>
To: Nicholas Miell <nmiell@comcast.net>
Cc: Suleiman Souhlal <ssouhlal@FreeBSD.org>,
Ulrich Drepper <drepper@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrea Arcangeli <andrea@suse.de>,
Badari Pulavarty <pbadari@us.ibm.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, hugh@veritas.com,
dvhltc@us.ibm.com, linux-mm@kvack.org, blaisorblade@yahoo.it,
jdike@addtoit.com, akpm@osdl.org
Subject: Re: differences between MADV_FREE and MADV_DONTNEED
Date: Tue, 17 Jan 2006 12:43:15 +0000 [thread overview]
Message-ID: <20060117124315.GA7754@infradead.org> (raw)
In-Reply-To: <1137459847.2842.6.camel@entropy>
On Mon, Jan 16, 2006 at 05:04:07PM -0800, Nicholas Miell wrote:
> On Mon, 2006-01-16 at 16:24 -0800, Suleiman Souhlal wrote:
> > Eric W. Biederman wrote:
> > > As I recall the logic with DONTNEED was to mark the mapping of
> > > the page clean so the page didn't need to be swapped out, it could
> > > just be dropped.
> > >
> > > That is why they anonymous and the file backed cases differ.
> > >
> > > Part of the point is to avoid the case of swapping the pages out if
> > > the application doesn't care what is on them anymore.
> >
> > Well, imho, MADV_DONTNEED should mean "I won't need this anytime soon",
> > and MADV_FREE "I will never need this again".
> >
>
> POSIX doesn't have a madvise(), but it does have a posix_madvise(), with
> flags defined as follows:
>
> POSIX_MADV_NORMAL
> Specifies that the application has no advice to give on its behavior
> with respect to the specified range. It is the default characteristic if
> no advice is given for a range of memory.
> POSIX_MADV_SEQUENTIAL
> Specifies that the application expects to access the specified range
> sequentially from lower addresses to higher addresses.
> POSIX_MADV_RANDOM
> Specifies that the application expects to access the specified range
> in a random order.
> POSIX_MADV_WILLNEED
> Specifies that the application expects to access the specified range
> in the near future.
> POSIX_MADV_DONTNEED
> Specifies that the application expects that it will not access the
> specified range in the near future.
>
> Note that glibc forwards posix_madvise() directly to madvise(2), which
> means that right now, POSIX conformant apps which use
> posix_madvise(addr, len, POSIX_MADV_DONTNEED) are silently corrupting
> data on Linux systems.
Does our MAD_DONTNEED numerical value match glibc's POSIX_MADV_DONTNEED?
In either case I'd say we should backout this patch for now. We should
implement a real MADV_DONTNEED and rename the current one to MADV_FREE,
but that's 2.6.17 material.
next prev parent reply other threads:[~2006-01-17 12:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1130366995.23729.38.camel@localhost.localdomain>
[not found] ` <20051028034616.GA14511@ccure.user-mode-linux.org>
[not found] ` <43624F82.6080003@us.ibm.com>
[not found] ` <20051028184235.GC8514@ccure.user-mode-linux.org>
[not found] ` <1130544201.23729.167.camel@localhost.localdomain>
[not found] ` <20051029025119.GA14998@ccure.user-mode-linux.org>
[not found] ` <1130788176.24503.19.camel@localhost.localdomain>
[not found] ` <20051101000509.GA11847@ccure.user-mode-linux.org>
2005-11-02 1:15 ` [PATCH] 2.6.14 patch for supporting madvise(MADV_FREE) Badari Pulavarty
2005-11-02 1:43 ` Andrea Arcangeli
2005-11-02 15:49 ` Badari Pulavarty
2005-11-02 16:12 ` [PATCH] 2.6.14 patch for supporting madvise(MADV_REMOVE) Badari Pulavarty
2005-11-02 19:54 ` New bug in patch and existing Linux code - race with install_page() (was: Re: [PATCH] 2.6.14 patch for supporting madvise(MADV_REMOVE)) Blaisorblade
2005-11-02 20:12 ` Hugh Dickins
2005-11-02 20:45 ` Hugh Dickins
2005-11-02 21:36 ` Badari Pulavarty
2005-11-02 21:55 ` Hugh Dickins
2005-11-02 22:02 ` Badari Pulavarty
2005-11-12 0:25 ` [PATCH] 2.6.14 patch for supporting madvise(MADV_REMOVE) Andrew Morton
2005-11-12 0:34 ` Badari Pulavarty
2005-11-12 1:43 ` Andrew Morton
2005-11-12 4:41 ` Badari Pulavarty
2006-01-16 13:06 ` differences between MADV_FREE and MADV_DONTNEED Andrea Arcangeli
2006-01-16 16:02 ` Suleiman Souhlal
2006-01-16 16:28 ` Andrea Arcangeli
2006-01-16 17:03 ` Suleiman Souhlal
2006-01-16 17:24 ` Andrea Arcangeli
2006-01-16 21:43 ` Eric W. Biederman
2006-01-17 0:24 ` Suleiman Souhlal
2006-01-17 1:04 ` Nicholas Miell
2006-01-17 12:43 ` Christoph Hellwig [this message]
2006-01-17 18:23 ` Eric W. Biederman
2006-01-17 22:55 ` Nicholas Miell
2007-03-01 18:11 ` Samuel Thibault
2006-01-17 19:06 ` Badari Pulavarty
2006-01-17 1:06 ` Blaisorblade
2006-01-17 1:33 ` Andrea Arcangeli
2005-11-12 0:34 ` [PATCH] 2.6.14 patch for supporting madvise(MADV_REMOVE) Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060117124315.GA7754@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=blaisorblade@yahoo.it \
--cc=drepper@redhat.com \
--cc=dvhltc@us.ibm.com \
--cc=ebiederm@xmission.com \
--cc=hugh@veritas.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nmiell@comcast.net \
--cc=pbadari@us.ibm.com \
--cc=ssouhlal@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox