The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Philippe Elie <phil.el@wanadoo.fr>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-kernel@vger.kernel.org, levon@movementarian.org,
	Al Viro <viro@ftp.linux.org.uk>
Subject: Re: make "struct d_cookie" dependable on CONFIG_PROFILING?
Date: Tue, 17 Jan 2006 16:06:45 +0100	[thread overview]
Message-ID: <20060117150645.GA775@zaniah> (raw)
In-Reply-To: <20060117122701.GA26491@dmt.cnet>

On Tue, 17 Jan 2006 at 10:27 +0000, Marcelo Tosatti wrote:


> Is there any good reason for not making "struct dcookie_struct
> *d_cookie" dependable on CONFIG_PROFILING? 
> 
> Shrinks "struct dentry" from 128 bytes to 124 on x86, allowing
> 31 objects per slab instead of 30.
> 
> John Levon informed me that he had such selection in his
> original patches, but was asked but take it off (?).

iirc this was seen usefull by other tools than profiler but 
fs/Makefile contains:

obj-$(CONFIG_PROFILING)		+= dcookies.o

and nobody complained agaisnt it.

-- 
regards,
Philippe Elie


      reply	other threads:[~2006-01-17 15:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-17 12:27 make "struct d_cookie" dependable on CONFIG_PROFILING? Marcelo Tosatti
2006-01-17 15:06 ` Philippe Elie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060117150645.GA775@zaniah \
    --to=phil.el@wanadoo.fr \
    --cc=levon@movementarian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox