public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: perex@suse.cz
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	D Binderman <dcb314@hotmail.com>
Subject: [2.6 patch] sound/pci/cs46xx/dsp_spos_scb_lib.c: fix an assertion
Date: Tue, 17 Jan 2006 19:47:01 +0100	[thread overview]
Message-ID: <20060117184701.GC19398@stusta.de> (raw)

D Binderman <dcb314@hotmail.com> reported the following in kernel 
Bugzilla #5903 [1]:


<--  snip  -->

I just tried to compile kernel 2.6.15.1 with the Intel C compiler. 

It said

sound/pci/cs46xx/dsp_spos_scb_lib.c(673): warning #187: use of "=" where 
"==" may have been intended

The source code is

           snd_assert (rate = 48000);

I agree with the compiler. Suggest new code

           snd_assert (rate == 48000);

<--  snip  -->


Thankfully this bug would only become visible if the assertion was 
false, but anyways it's a bug.

[1] http://bugzilla.kernel.org/show_bug.cgi?id=5903


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.15-mm4-full/sound/pci/cs46xx/dsp_spos_scb_lib.c.old	2006-01-16 20:20:23.000000000 +0100
+++ linux-2.6.15-mm4-full/sound/pci/cs46xx/dsp_spos_scb_lib.c	2006-01-16 20:21:17.000000000 +0100
@@ -677,7 +677,7 @@
 		if (pass_through) {
 			/* wont work with any other rate than
 			   the native DSP rate */
-			snd_assert (rate = 48000);
+			snd_assert (rate == 48000);
 
 			scb = cs46xx_dsp_create_generic_scb(chip,scb_name,(u32 *)&src_task_scb,
 							    dest,"DMAREADER",parent_scb,


             reply	other threads:[~2006-01-17 18:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-17 18:47 Adrian Bunk [this message]
2006-01-17 18:52 ` [Alsa-devel] [2.6 patch] sound/pci/cs46xx/dsp_spos_scb_lib.c: fix an assertion Lee Revell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060117184701.GC19398@stusta.de \
    --to=bunk@stusta.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dcb314@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox