From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Olaf Hering <olh@suse.de>
Cc: Kumar Gala <galak@gate.crashing.org>,
Kumar Gala <galak@kernel.crashing.org>,
Dmitry Torokhov <dtor_core@ameritech.net>,
Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [patch 6/6] serial8250: convert to the new platform device interface
Date: Wed, 18 Jan 2006 09:56:43 +0000 [thread overview]
Message-ID: <20060118095642.GA20588@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20060117193604.GA25724@suse.de>
On Tue, Jan 17, 2006 at 08:36:04PM +0100, Olaf Hering wrote:
> On Mon, Jan 16, Kumar Gala wrote:
> > > Mea Culpa - should've spotted that - that patch is actually rather
> > > broken. platform_driver_register() can't be moved from where it
> > > initially was.
> >
> > This seems to fix my issue on arch/powerpc and arch/ppc, please push to
> > Linus ASAP.
>
> This fixes also my pseries, p270. Too bad, the 8250 depends on
> CONFIG_ISA now which is not selectable for CONFIG_PPC_PSERIES.
> Is this patch the way to go for ppc64?
8250 does not depend on ISA - at least not in mainline. If it did depend
on ISA, that would be completely wrong.
ISA should be set if you have ISA slots on your motherboard (as the help
says). The presence of 8250 devices does not depend on whether you have
ISA slots or not.
Patch rejected.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-01-18 9:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-11 6:47 [patch 0/6] Assorted conversions to the new platform device interface Dmitry Torokhov
2006-01-11 6:47 ` [patch 1/6] hdaps: convert " Dmitry Torokhov
2006-01-11 6:47 ` [patch 2/6] vr41xx: " Dmitry Torokhov
2006-01-11 6:47 ` [patch 3/6] mv64x600_wdt: " Dmitry Torokhov
2006-01-11 6:47 ` [patch 4/6] tb0219: " Dmitry Torokhov
2006-01-11 6:47 ` [patch 5/6] dcdbas: " Dmitry Torokhov
2006-01-11 6:47 ` [patch 6/6] serial8250: " Dmitry Torokhov
2006-01-16 22:27 ` Kumar Gala
2006-01-16 23:31 ` Russell King
2006-01-16 23:54 ` Kumar Gala
2006-01-17 2:35 ` Tony Lindgren
2006-01-17 19:36 ` Olaf Hering
2006-01-18 9:56 ` Russell King [this message]
2006-01-18 10:10 ` Olaf Hering
2006-01-18 11:03 ` Olaf Hering
2006-01-17 21:41 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060118095642.GA20588@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=galak@gate.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox