From: Dave Jones <davej@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@osdl.org>,
Reuben Farrelly <reuben-lkml@reub.net>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
arjan@infradead.org
Subject: Re: 2.6.16-rc1-mm1
Date: Wed, 18 Jan 2006 18:37:39 -0500 [thread overview]
Message-ID: <20060118233739.GH5278@redhat.com> (raw)
In-Reply-To: <1137626021.1760.18.camel@localhost.localdomain>
On Wed, Jan 18, 2006 at 11:13:41PM +0000, Alan Cox wrote:
> On Mer, 2006-01-18 at 14:09 -0500, Dave Jones wrote:
> > On Wed, Jan 18, 2006 at 03:27:16AM -0800, Andrew Morton wrote:
> >
> > > Well yes, that code is kfree()ing a locked mutex. It's somewhat weird to
> > > take a lock on a still-private object but whatever. The code's legal
> > > enough.
> > >
>
> If someone else can be waiting on it then it doesn't look legal ?
it's allocated in this function, and we only kfree it in an error path
if something goes wrong. If we get to the kfree, the policy has
never been seen anywhere outside of cpufreq_add_dev(), so nothing
else can be waiting on it.
Dave
next prev parent reply other threads:[~2006-01-18 23:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-18 8:50 2.6.16-rc1-mm1 Andrew Morton
2006-01-18 10:45 ` [PATCH] mempolicy.c compile fix Dominik Karall
2006-01-18 10:55 ` 2.6.16-rc1-mm1 Dominik Karall
2006-01-18 13:19 ` snd_pcm_format_name() problems [Re: 2.6.16-rc1-mm1] Jiri Slaby
2006-01-18 11:10 ` 2.6.16-rc1-mm1 Reuben Farrelly
2006-01-18 11:27 ` 2.6.16-rc1-mm1 Andrew Morton
2006-01-18 19:09 ` 2.6.16-rc1-mm1 Dave Jones
2006-01-18 21:40 ` 2.6.16-rc1-mm1 Andrew Morton
2006-01-18 21:56 ` 2.6.16-rc1-mm1 Dave Jones
2006-01-18 23:13 ` 2.6.16-rc1-mm1 Alan Cox
2006-01-18 23:37 ` Dave Jones [this message]
2006-01-19 7:16 ` 2.6.16-rc1-mm1 Arjan van de Ven
2006-01-18 11:53 ` [PATCH] migrate_page_add mangled brackets during merge Andy Whitcroft
2006-01-18 12:00 ` 2.6.16-rc1-mm1 Grant Coady
2006-01-18 12:41 ` 2.6.16-rc1-mm1 Reuben Farrelly
2006-01-18 22:29 ` Wireless issues (was 2.6.16-rc1-mm1 Valdis.Kletnieks
2006-01-18 22:56 ` Andrew Morton
2006-01-19 7:33 ` Valdis.Kletnieks
2006-01-19 9:33 ` Wireless issues (was Re: 2.6.16-rc1-mm1) Dominik Brodowski
2006-01-19 1:05 ` [-mm patch] make pcmcia_release_{io,irq} static Adrian Bunk
2006-01-19 11:14 ` Dominik Brodowski
2006-01-19 3:11 ` 2.6.16-rc1-mm1: ia64 compile error Adrian Bunk
2006-01-19 3:27 ` Greg KH
2006-01-19 3:31 ` Mark Maule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060118233739.GH5278@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=reuben-lkml@reub.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox