Re: [PATCH] e1000 C style badness

[Jens Axboe <axboe@suse.de>]

On Wed, Jan 18 2006, Jesse Brandeburg wrote:
> On 1/18/06, Jens Axboe <axboe@suse.de> wrote:
> > On Wed, Jan 18 2006, Jeff Garzik wrote:
> > > We'll get it fixed ASAP, even if it means reverting all those patches.
> >
> > Thanks, it is rather critical. At least it didn't get included in -rc1,
> > that would have been a disaster :-)
> 
> just FYI, I have a patch for the e1000 breakage which will be out as
> soon as I can generate it.

Newest -git works for me. Well sort of, I get a lot of these:

e1000: eth0: e1000_watchdog_task: NIC Link is Up 1000 Mbps Full Duplex
e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang
  Tx Queue             <0>
  TDH                  <72>
  TDT                  <e5>
  next_to_use          <e5>
  next_to_clean        <6f>
buffer_info[next_to_clean]
  time_stamp           <10000160a>
  next_to_watch        <72>
  jiffies              <100001e09>
  next_to_watch.status <0>
e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang
  Tx Queue             <0>
  TDH                  <72>
  TDT                  <e5>
  next_to_use          <e5>
  next_to_clean        <6f>
buffer_info[next_to_clean]
  time_stamp           <10000160a>
  next_to_watch        <72>
  jiffies              <1000025da>
  next_to_watch.status <0>
e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang
  Tx Queue             <0>
  TDH                  <72>
  TDT                  <e5>
  next_to_use          <e5>
  next_to_clean        <6f>
buffer_info[next_to_clean]
  time_stamp           <10000160a>
  next_to_watch        <72>
  jiffies              <10000357b>
  next_to_watch.status <0>
NETDEV WATCHDOG: eth0: transmit timed out
e1000: eth0: e1000_watchdog_task: NIC Link is Up 1000 Mbps Full Duplex


-- 
Jens Axboe