public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* EDAC config cleanup
@ 2006-01-19 22:10 Dave Jones
  2006-01-19 22:12 ` Randy.Dunlap
  2006-01-19 22:30 ` Alan Cox
  0 siblings, 2 replies; 5+ messages in thread
From: Dave Jones @ 2006-01-19 22:10 UTC (permalink / raw)
  To: Linux Kernel; +Cc: alan

The AMD76x chipsets aren't used in 64-bit, so don't
offer the driver to the user.

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6.15.noarch/drivers/edac/Kconfig~	2006-01-19 17:00:16.000000000 -0500
+++ linux-2.6.15.noarch/drivers/edac/Kconfig	2006-01-19 17:03:33.000000000 -0500
@@ -46,7 +46,7 @@ config EDAC_MM_EDAC
 
 config EDAC_AMD76X
 	tristate "AMD 76x (760, 762, 768)"
-	depends on EDAC_MM_EDAC  && PCI
+	depends on EDAC_MM_EDAC && PCI X86_32
 	help
 	  Support for error detection and correction on the AMD 76x
 	  series of chipsets used with the Athlon processor.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: EDAC config cleanup
  2006-01-19 22:10 EDAC config cleanup Dave Jones
@ 2006-01-19 22:12 ` Randy.Dunlap
  2006-01-19 22:23   ` Dave Jones
  2006-01-19 22:30 ` Alan Cox
  1 sibling, 1 reply; 5+ messages in thread
From: Randy.Dunlap @ 2006-01-19 22:12 UTC (permalink / raw)
  To: Dave Jones; +Cc: Linux Kernel, alan

On Thu, 19 Jan 2006, Dave Jones wrote:

> The AMD76x chipsets aren't used in 64-bit, so don't
> offer the driver to the user.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6.15.noarch/drivers/edac/Kconfig~	2006-01-19 17:00:16.000000000 -0500
> +++ linux-2.6.15.noarch/drivers/edac/Kconfig	2006-01-19 17:03:33.000000000 -0500
> @@ -46,7 +46,7 @@ config EDAC_MM_EDAC
>
>  config EDAC_AMD76X
>  	tristate "AMD 76x (760, 762, 768)"
> -	depends on EDAC_MM_EDAC  && PCI
> +	depends on EDAC_MM_EDAC && PCI X86_32
                                      ^ && ???

>  	help
>  	  Support for error detection and correction on the AMD 76x
>  	  series of chipsets used with the Athlon processor.
> -

-- 
~Randy

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: EDAC config cleanup
  2006-01-19 22:12 ` Randy.Dunlap
@ 2006-01-19 22:23   ` Dave Jones
  2006-01-19 22:30     ` Alan Cox
  0 siblings, 1 reply; 5+ messages in thread
From: Dave Jones @ 2006-01-19 22:23 UTC (permalink / raw)
  To: Randy.Dunlap; +Cc: Linux Kernel, alan

On Thu, Jan 19, 2006 at 02:12:11PM -0800, Randy.Dunlap wrote:

 > > +	depends on EDAC_MM_EDAC && PCI X86_32
 >                                       ^ && ???

Gah. Of course.  (That'll teach me to not test 'obvious' patches :)
Here it is again, unborked. (tested with make ARCH=x86_64 menuconfig)


The AMD76x chipsets aren't used in 64-bit, so don't
offer the driver to the user.

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6.15.noarch/drivers/edac/Kconfig~	2006-01-19 17:00:16.000000000 -0500
+++ linux-2.6.15.noarch/drivers/edac/Kconfig	2006-01-19 17:03:33.000000000 -0500
@@ -46,7 +46,7 @@ config EDAC_MM_EDAC
 
 config EDAC_AMD76X
 	tristate "AMD 76x (760, 762, 768)"
-	depends on EDAC_MM_EDAC  && PCI
+	depends on EDAC_MM_EDAC && PCI && X86_32
 	help
 	  Support for error detection and correction on the AMD 76x
 	  series of chipsets used with the Athlon processor.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: EDAC config cleanup
  2006-01-19 22:10 EDAC config cleanup Dave Jones
  2006-01-19 22:12 ` Randy.Dunlap
@ 2006-01-19 22:30 ` Alan Cox
  1 sibling, 0 replies; 5+ messages in thread
From: Alan Cox @ 2006-01-19 22:30 UTC (permalink / raw)
  To: Dave Jones, Linux Kernel, alan

On Thu, Jan 19, 2006 at 05:10:06PM -0500, Dave Jones wrote:
> -	depends on EDAC_MM_EDAC  && PCI
> +	depends on EDAC_MM_EDAC && PCI X86_32

NAK  add another &&

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: EDAC config cleanup
  2006-01-19 22:23   ` Dave Jones
@ 2006-01-19 22:30     ` Alan Cox
  0 siblings, 0 replies; 5+ messages in thread
From: Alan Cox @ 2006-01-19 22:30 UTC (permalink / raw)
  To: Dave Jones, Randy.Dunlap, Linux Kernel, alan

On Thu, Jan 19, 2006 at 05:23:50PM -0500, Dave Jones wrote:
> The AMD76x chipsets aren't used in 64-bit, so don't
> offer the driver to the user.
> 
> Signed-off-by: Dave Jones <davej@redhat.com>

Acked-by: Alan Cox <alan@redhat.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2006-01-19 22:30 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-19 22:10 EDAC config cleanup Dave Jones
2006-01-19 22:12 ` Randy.Dunlap
2006-01-19 22:23   ` Dave Jones
2006-01-19 22:30     ` Alan Cox
2006-01-19 22:30 ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox