public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] X86_GX_SUSPMOD must depend on PCI
@ 2005-11-21 22:33 Adrian Bunk
  0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2005-11-21 22:33 UTC (permalink / raw)
  To: davej; +Cc: cpufreq, linux-kernel

This patch fixes the following compile error:

...
  CC      arch/i386/kernel/cpu/cpufreq/gx-suspmod.o
arch/i386/kernel/cpu/cpufreq/gx-suspmod.c: In function 'gx_detect_chipset':
arch/i386/kernel/cpu/cpufreq/gx-suspmod.c:193: error: implicit declaration of function 'pci_match_id'
arch/i386/kernel/cpu/cpufreq/gx-suspmod.c:193: warning: comparison between pointer and integer
make[3]: *** [arch/i386/kernel/cpu/cpufreq/gx-suspmod.o] Error 1

<--  snip  -->


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.15-rc1-mm2-full/arch/i386/kernel/cpu/cpufreq/Kconfig.old	2005-11-21 19:59:21.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/arch/i386/kernel/cpu/cpufreq/Kconfig	2005-11-21 19:59:48.000000000 +0100
@@ -96,6 +96,7 @@
 
 config X86_GX_SUSPMOD
 	tristate "Cyrix MediaGX/NatSemi Geode Suspend Modulation"
+	depends on PCI
 	help
 	 This add the CPUFreq driver for NatSemi Geode processors which
 	 support suspend modulation.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [2.6 patch] X86_GX_SUSPMOD must depend on PCI
@ 2006-01-20  0:25 Adrian Bunk
  2006-01-20  0:45 ` Dave Jones
  0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2006-01-20  0:25 UTC (permalink / raw)
  To: davej; +Cc: cpufreq, linux-kernel

This patch fixes the following compile error:

...
  CC      arch/i386/kernel/cpu/cpufreq/gx-suspmod.o
arch/i386/kernel/cpu/cpufreq/gx-suspmod.c: In function 'gx_detect_chipset':
arch/i386/kernel/cpu/cpufreq/gx-suspmod.c:193: error: implicit declaration of function 'pci_match_id'
arch/i386/kernel/cpu/cpufreq/gx-suspmod.c:193: warning: comparison between pointer and integer
make[3]: *** [arch/i386/kernel/cpu/cpufreq/gx-suspmod.o] Error 1

<--  snip  -->


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

This patch was already sent on:
- 21 Nov 2005

--- linux-2.6.15-rc1-mm2-full/arch/i386/kernel/cpu/cpufreq/Kconfig.old	2005-11-21 19:59:21.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/arch/i386/kernel/cpu/cpufreq/Kconfig	2005-11-21 19:59:48.000000000 +0100
@@ -96,6 +96,7 @@
 
 config X86_GX_SUSPMOD
 	tristate "Cyrix MediaGX/NatSemi Geode Suspend Modulation"
+	depends on PCI
 	help
 	 This add the CPUFreq driver for NatSemi Geode processors which
 	 support suspend modulation.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [2.6 patch] X86_GX_SUSPMOD must depend on PCI
  2006-01-20  0:25 [2.6 patch] X86_GX_SUSPMOD must depend on PCI Adrian Bunk
@ 2006-01-20  0:45 ` Dave Jones
  0 siblings, 0 replies; 4+ messages in thread
From: Dave Jones @ 2006-01-20  0:45 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: cpufreq, linux-kernel

On Fri, Jan 20, 2006 at 01:25:37AM +0100, Adrian Bunk wrote:
 > This patch fixes the following compile error:
 > 
 > ...
 >   CC      arch/i386/kernel/cpu/cpufreq/gx-suspmod.o
 > arch/i386/kernel/cpu/cpufreq/gx-suspmod.c: In function 'gx_detect_chipset':
 > arch/i386/kernel/cpu/cpufreq/gx-suspmod.c:193: error: implicit declaration of function 'pci_match_id'
 > arch/i386/kernel/cpu/cpufreq/gx-suspmod.c:193: warning: comparison between pointer and integer
 > make[3]: *** [arch/i386/kernel/cpu/cpufreq/gx-suspmod.o] Error 1
 > 
 > <--  snip  -->
 > 
 > 
 > Signed-off-by: Adrian Bunk <bunk@stusta.de>

Applied, thanks Adrian.

		Dave


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [2.6 patch] X86_GX_SUSPMOD must depend on PCI
@ 2006-07-08 20:20 Adrian Bunk
  0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2006-07-08 20:20 UTC (permalink / raw)
  To: Dave Jones; +Cc: cpufreq, linux-kernel

It seems commit 32ee8c3e470d86588b51dc42ed01e85c5fa0f180 accidentially 
reverted cdc9cc1d740ffc3d8d8207fbf5df9bf05fcc9955, IOW, it reintroduced 
the following compile error with CONFIG_PCI=n:

<--  snip  -->

...
  CC      arch/i386/kernel/cpu/cpufreq/gx-suspmod.o
arch/i386/kernel/cpu/cpufreq/gx-suspmod.c: In function ‘gx_detect_chipset’:
arch/i386/kernel/cpu/cpufreq/gx-suspmod.c:193: error: implicit declaration of function ‘pci_match_id’
arch/i386/kernel/cpu/cpufreq/gx-suspmod.c:193: warning: comparison between pointer and integer
make[3]: *** [arch/i386/kernel/cpu/cpufreq/gx-suspmod.o] Error 1

<--  snip  -->

This patch therefore re-adds the dependency of X86_GX_SUSPMOD on PCI.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.17-mm6-full/arch/i386/kernel/cpu/cpufreq/Kconfig.old	2006-07-08 17:29:40.000000000 +0200
+++ linux-2.6.17-mm6-full/arch/i386/kernel/cpu/cpufreq/Kconfig	2006-07-08 17:29:53.000000000 +0200
@@ -96,6 +96,7 @@
 
 config X86_GX_SUSPMOD
 	tristate "Cyrix MediaGX/NatSemi Geode Suspend Modulation"
+	depends on PCI
 	help
 	 This add the CPUFreq driver for NatSemi Geode processors which
 	 support suspend modulation.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-07-08 20:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-20  0:25 [2.6 patch] X86_GX_SUSPMOD must depend on PCI Adrian Bunk
2006-01-20  0:45 ` Dave Jones
  -- strict thread matches above, loose matches on Subject: below --
2006-07-08 20:20 Adrian Bunk
2005-11-21 22:33 Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox