public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: thomas@winischhofer.net, gregkh@suse.de,
	linux-usb-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/usb/misc/sisusbvga/: possible cleanups
Date: Thu, 19 Jan 2006 17:11:32 -0800	[thread overview]
Message-ID: <20060120011132.GA28981@kroah.com> (raw)
In-Reply-To: <20060119011854.GV19398@stusta.de>

On Thu, Jan 19, 2006 at 02:18:54AM +0100, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make needlessly global functions static
> - function and struct declarations belong into header files
> - make SiS_VCLKData const
> - #if 0 the following unused global functions:
>   - sisusb.c: sisusb_writew()
>   - sisusb.c: sisusb_readw()
>   - sisusb_init.c: SiSUSB_GetModeID()
> 
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

For some reason, this doesn't apply.  Care to rediff it?

thanks,

greg k-h

  reply	other threads:[~2006-01-20  1:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-19  1:18 [2.6 patch] drivers/usb/misc/sisusbvga/: possible cleanups Adrian Bunk
2006-01-20  1:11 ` Greg KH [this message]
2006-01-20 20:41   ` Adrian Bunk
  -- strict thread matches above, loose matches on Subject: below --
2006-04-15  9:17 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060120011132.GA28981@kroah.com \
    --to=greg@kroah.com \
    --cc=bunk@stusta.de \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=thomas@winischhofer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox