Re: [2.6 patch] drivers/usb/misc/sisusbvga/: possible cleanups

Adrian Bunk
2006-01-20T20:41:41Z

On Thu, Jan 19, 2006 at 05:11:32PM -0800, Greg KH wrote:
> On Thu, Jan 19, 2006 at 02:18:54AM +0100, Adrian Bunk wrote:
> > This patch contains the following possible cleanups:
> > - make needlessly global functions static
> > - function and struct declarations belong into header files
> > - make SiS_VCLKData const
> > - #if 0 the following unused global functions:
> > - sisusb.c: sisusb_writew()
> > - sisusb.c: sisusb_readw()
> > - sisusb_init.c: SiSUSB_GetModeID()
> >
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> For some reason, this doesn't apply. Care to rediff it?

My patch was made against -mm which contains
convert-the-semaphores-in-the-sisusb-driver-to-mutexes.patch.

Should I rediff or should I wait until you've merged this patch?

> thanks,
>
> greg k-h

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed