From: Jens Axboe <axboe@suse.de>
To: Nate Diller <nate.diller@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
cmm@us.ibm.com, seelam@cs.utep.edu, linux-kernel@vger.kernel.org,
ext2-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2][RESEND] Default iosched fixes (was: Fall back io scheduler for 2.6.15?)
Date: Sat, 21 Jan 2006 12:48:41 +0100 [thread overview]
Message-ID: <20060121114841.GT13429@suse.de> (raw)
In-Reply-To: <5c49b0ed0601201517h3126ac8dp931bab93a85bf9c5@mail.gmail.com>
On Fri, Jan 20 2006, Nate Diller wrote:
> My previous default iosched patch did a poor job dealing with the
> 'elevator=' boot-time option. The old behavior falls back to the
> compiled-in default if the requested one is not registered at boot
> time. This patch dynamically evaluates which default
> to use, and emits a suitable error message when the requested scheduler
> is not available. It also does the 'as' -> 'anticipatory' conversion
> before elevator registration, which along with a modified registration
> function, allows it to correctly indicate which default scheduler is
> in use.
I'm a little confused by your description - what problem does this patch
actually solve? We already fall back to the default, and we already do
the "as" conversion. It does seem to cleanup the code, just curious
since your description seems to promise a little more than what it
actually adds.
--
Jens Axboe
next prev parent reply other threads:[~2006-01-21 11:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 0:04 [PATCH] Default iosched fixes (was: Fall back io scheduler for 2.6.15?) Nate Diller
2006-01-20 8:11 ` Jens Axboe
2006-01-20 23:17 ` [PATCH 1/2][RESEND] " Nate Diller
2006-01-20 23:24 ` [PATCH 2/2][RESEND] " Nate Diller
2006-01-21 11:40 ` Jens Axboe
2006-01-21 11:48 ` Jens Axboe [this message]
2006-01-23 19:50 ` [PATCH 1/2][RESEND] " Nate Diller
2006-01-23 21:02 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060121114841.GT13429@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=cmm@us.ibm.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nate.diller@gmail.com \
--cc=seelam@cs.utep.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox