From: "George G. Davis" <gdavis@mvista.com>
To: rmk+serial@arm.linux.org.uk
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] serial: Add spin_lock_init() in 8250 early_serial_setup() to init port.lock
Date: Wed, 25 Jan 2006 22:24:03 -0500 [thread overview]
Message-ID: <20060126032403.GG5133@mvista.com> (raw)
Need spin_lock_init(&serial8250_ports[port->line].port.lock) in
early_serial_setup() since we're copying struct uart_port *port
into serial8250_ports[port->line].port and *port.lock is typically
unitiliased by the caller.
Signed-off-by: George G. Davis <gdavis@mvista.com>
Index: linux-2.6/drivers/serial/8250.c
===================================================================
--- linux-2.6.orig/drivers/serial/8250.c
+++ linux-2.6/drivers/serial/8250.c
@@ -2340,6 +2340,7 @@ int __init early_serial_setup(struct uar
serial8250_isa_init_ports();
serial8250_ports[port->line].port = *port;
serial8250_ports[port->line].port.ops = &serial8250_pops;
+ spin_lock_init(&serial8250_ports[port->line].port.lock);
return 0;
}
next reply other threads:[~2006-01-26 3:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-26 3:24 George G. Davis [this message]
2006-01-30 15:39 ` [PATCH] serial: Add spin_lock_init() in 8250 early_serial_setup() to init port.lock Atsushi Nemoto
2006-02-01 15:45 ` George G. Davis
2006-02-01 16:01 ` Atsushi Nemoto
2006-02-01 17:00 ` George G. Davis
2006-02-01 23:00 ` Russell King
2006-02-02 1:25 ` George G. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060126032403.GG5133@mvista.com \
--to=gdavis@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox