From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>,
"V. Ananda Krishnan" <mansarov@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: [RFC: -mm patch] drivers/serial/jsm/: cleanups
Date: Thu, 26 Jan 2006 23:23:45 +0100 [thread overview]
Message-ID: <20060126222345.GB3668@stusta.de> (raw)
In-Reply-To: <20060124232406.50abccd1.akpm@osdl.org>
On Tue, Jan 24, 2006 at 11:24:06PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc1-mm2:
>...
> +jsm-update-for-tty-buffering-revamp.patch
>...
> Misc.
>...
This patch contains the following cleanups:
- jsm_driver.c: remove the now unused jsm_rawreadok module_param
- jsm_tty.c: remove a now unused variable
Is there any problem with removing the now useless jsm_rawreadok
module_param?
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/serial/jsm/jsm.h | 1 -
drivers/serial/jsm/jsm_driver.c | 3 ---
drivers/serial/jsm/jsm_tty.c | 1 -
3 files changed, 5 deletions(-)
--- linux-2.6.16-rc1-mm3-full/drivers/serial/jsm/jsm.h.old 2006-01-25 23:15:38.000000000 +0100
+++ linux-2.6.16-rc1-mm3-full/drivers/serial/jsm/jsm.h 2006-01-25 23:15:43.000000000 +0100
@@ -380,7 +380,6 @@
extern struct uart_driver jsm_uart_driver;
extern struct board_ops jsm_neo_ops;
extern int jsm_debug;
-extern int jsm_rawreadok;
/*************************************************************************
*
--- linux-2.6.16-rc1-mm3-full/drivers/serial/jsm/jsm_driver.c.old 2006-01-25 23:15:51.000000000 +0100
+++ linux-2.6.16-rc1-mm3-full/drivers/serial/jsm/jsm_driver.c 2006-01-25 23:15:57.000000000 +0100
@@ -49,11 +49,8 @@
};
int jsm_debug;
-int jsm_rawreadok;
module_param(jsm_debug, int, 0);
-module_param(jsm_rawreadok, int, 0);
MODULE_PARM_DESC(jsm_debug, "Driver debugging level");
-MODULE_PARM_DESC(jsm_rawreadok, "Bypass flip buffers on input");
static int jsm_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent)
{
--- linux-2.6.16-rc1-mm3-full/drivers/serial/jsm/jsm_tty.c.old 2006-01-25 23:19:13.000000000 +0100
+++ linux-2.6.16-rc1-mm3-full/drivers/serial/jsm/jsm_tty.c 2006-01-25 23:19:35.000000000 +0100
@@ -512,7 +512,6 @@
int flip_len = 0;
int len = 0;
int n = 0;
- char *buf = NULL;
int s = 0;
int i = 0;
next prev parent reply other threads:[~2006-01-26 22:23 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 7:24 2.6.16-rc1-mm3 Andrew Morton
2006-01-25 8:38 ` [PATCH] convert a for (i = 0 ; i < NR_CPUS ; i++) to for_each_cpu(i) in sched_init() Eric Dumazet
2006-01-25 8:42 ` [PATCH, resent] " Eric Dumazet
2006-01-25 9:14 ` [PATCH] convert a for (i = 0 ; i < NR_CPUS ; i++) to for_each_cpu(i) in files_defer_init() Eric Dumazet
2006-01-25 12:01 ` [PATCH, resent] convert a for (i = 0 ; i < NR_CPUS ; i++) to for_each_cpu(i) in sched_init() Ingo Molnar
2006-01-25 9:01 ` [PATCH] mips: follow the change of split_page() Yoichi Yuasa
2006-01-25 9:16 ` 2.6.16-rc1-mm3: mips, sparc64 split_page breakage Alexey Dobriyan
2006-01-25 9:26 ` [PATCH -mm] Mark ppc_htab_operations as const Alexey Dobriyan
2006-01-25 9:32 ` [PATCH -mm] s390: dasd_eckd: add missing } Alexey Dobriyan
2006-01-25 10:44 ` 2.6.16-rc1-mm3 Reuben Farrelly
2006-01-26 5:39 ` [linux-usb-devel] 2.6.16-rc1-mm3 Greg KH
2006-01-27 12:46 ` Reuben Farrelly
2006-01-27 17:27 ` Greg KH
2006-01-27 17:49 ` 2.6.16-rc1-mm3 Pete Zaitcev
2006-01-27 19:40 ` 2.6.16-rc1-mm3 Reuben Farrelly
2006-01-27 19:57 ` 2.6.16-rc1-mm3 Pete Zaitcev
2006-01-25 11:40 ` 2.6.16-rc1-mm3 Michal Piotrowski
2006-01-25 15:59 ` 2.6.16-rc1-mm3 Nick Piggin
2006-01-26 19:02 ` 2.6.16-rc1-mm3 Michal Piotrowski
2006-01-26 19:47 ` 2.6.16-rc1-mm3 Nick Piggin
2006-01-26 19:50 ` 2.6.16-rc1-mm3 Nick Piggin
2006-01-27 10:11 ` 2.6.16-rc1-mm3 Michal Piotrowski
2006-02-01 8:30 ` 2.6.16-rc1-mm3 Nick Piggin
2006-02-01 8:51 ` 2.6.16-rc1-mm3 Andrew Morton
2006-02-02 21:06 ` 2.6.16-rc1-mm3 Michal Piotrowski
2006-02-02 22:20 ` 2.6.16-rc1-mm3 Andrew Morton
2006-02-02 23:48 ` 2.6.16-rc1-mm3 Michal Piotrowski
2006-02-03 0:12 ` 2.6.16-rc1-mm3 Michal Piotrowski
2006-01-26 19:58 ` 2.6.16-rc1-mm3 Michal Piotrowski
2006-01-25 14:06 ` 2.6.16-rc1-mm3 Andy Whitcroft
2006-01-25 14:44 ` 2.6.16-rc1-mm3 Pekka Enberg
2006-01-25 16:46 ` 2.6.16-rc1-mm3 Andy Whitcroft
2006-01-25 18:16 ` 2.6.16-rc1-mm3 Pekka Enberg
2006-01-25 21:06 ` 2.6.16-rc1-mm3 Andy Whitcroft
2006-01-26 7:03 ` 2.6.16-rc1-mm3 Pekka Enberg
2006-01-27 0:20 ` 2.6.16-rc1-mm3 Andy Whitcroft
2006-01-27 3:23 ` 2.6.16-rc1-mm3 Andrew Morton
2006-01-27 6:03 ` 2.6.16-rc1-mm3 Eric Dumazet
2006-01-27 10:12 ` 2.6.16-rc1-mm3 Andy Whitcroft
2006-01-27 10:37 ` 2.6.16-rc1-mm3 Eric Dumazet
2006-01-25 19:55 ` 2.6.16-rc1-mm3 / netfilter / firehol problems? thunder7
2006-01-25 20:59 ` Jiri Slaby
2006-01-26 8:29 ` Harald Welte
2006-01-26 5:29 ` [BUG] Invalid sleeping function call in 2.6.16-rc1-mm3 Peter Williams
2006-01-26 18:13 ` 2.6.16-rc1-mm3 (soft lockup) Dominik Karall
2006-01-26 19:01 ` 2.6.16-rc1-mm3 (psmouse.c) Dominik Karall
2006-01-26 22:23 ` Adrian Bunk [this message]
2006-01-27 11:47 ` 2.6.16-rc1-mm3 Reuben Farrelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060126222345.GB3668@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mansarov@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox