From: Ingo Molnar <mingo@elte.hu>
To: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: nickpiggin@yahoo.com.au, ak@suse.de,
linux-kernel@vger.kernel.org, rohit.seth@intel.com,
asit.k.mallick@intel.com, Andrew Morton <akpm@osdl.org>
Subject: Re: [Patch] sched: new sched domain for representing multi-core
Date: Fri, 27 Jan 2006 01:08:54 +0100 [thread overview]
Message-ID: <20060127000854.GA16332@elte.hu> (raw)
In-Reply-To: <20060126015132.A8521@unix-os.sc.intel.com>
a few minor nits:
* Siddha, Suresh B <suresh.b.siddha@intel.com> wrote:
> +config SCHED_MC
> + bool "Multi-core scheduler support"
> + depends on SMP
> + default off
no need to add 'default off', that's the default.
> -#ifdef CONFIG_SCHED_SMT
> +#if defined(CONFIG_SCHED_SMT)
stale change.
Otherwise, looks pretty clean to me, both the scheduler and the x86_*
arch level bits! Would be nice to get this tested in -mm too.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2006-01-27 0:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-26 9:51 [Patch] sched: new sched domain for representing multi-core Siddha, Suresh B
2006-01-27 0:08 ` Ingo Molnar [this message]
2006-01-27 3:51 ` Siddha, Suresh B
2006-01-28 0:00 ` Andrew Morton
2006-01-31 1:28 ` Siddha, Suresh B
2006-02-01 1:12 ` Andrew Morton
2006-02-01 1:48 ` Siddha, Suresh B
2006-02-01 2:21 ` Andrew Morton
2006-02-01 2:52 ` Siddha, Suresh B
2006-01-27 4:42 ` Andi Kleen
2006-01-28 1:45 ` Siddha, Suresh B
2006-01-29 16:56 ` Pavel Machek
2006-01-31 1:31 ` Siddha, Suresh B
-- strict thread matches above, loose matches on Subject: below --
2006-02-09 9:59 Samuel Thibault
2006-02-11 0:51 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060127000854.GA16332@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=asit.k.mallick@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=rohit.seth@intel.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox