From: Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk>
To: Greg KH <greg@kroah.com>
Cc: "Mike D. Day" <ncmike@us.ibm.com>,
xen-devel@lists.xensource.com,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.12.6-xen] sysfs attributes for xen
Date: Sat, 28 Jan 2006 13:23:35 +0100 [thread overview]
Message-ID: <20060128122335.GA24382@snarc.org> (raw)
In-Reply-To: <20060128023828.GA20881@kroah.com>
On Fri, Jan 27, 2006 at 06:38:28PM -0800, Greg KH wrote:
> > +
> > +int __init
> > +hyper_sysfs_init(void)
> > +{
> > + int err ;
> > +
> > + if( 0 == (err = subsystem_register(&hypervisor_subsys)) ) {
> > + xen_kset.subsys = &hypervisor_subsys;
> > + err = kset_register(&xen_kset);
> > + }
>
> Is this the xen coding style? If so, it's got to change before making
> it into mainline... Please fix this up.
No, this is not coding style we use for linux related files.
The patch really need to be fix ...
--
Vincent Hanquez
next prev parent reply other threads:[~2006-01-28 12:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-28 2:20 [PATCH 2.6.12.6-xen] sysfs attributes for xen Mike D. Day
2006-01-28 2:25 ` Greg KH
2006-01-28 2:38 ` Greg KH
2006-01-28 12:23 ` Vincent Hanquez [this message]
2006-01-28 3:03 ` [Xen-devel] " Anthony Liguori
2006-01-30 16:18 ` Dave Hansen
2006-01-30 16:58 ` [Xen-devel] " Mike D. Day
2006-01-30 17:04 ` Dave Hansen
2006-01-30 17:17 ` Mike D. Day
2006-01-30 17:26 ` Greg KH
2006-01-30 17:38 ` Dave Hansen
2006-01-30 17:53 ` Keir Fraser
2006-01-30 17:56 ` Dave Hansen
2006-01-30 19:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060128122335.GA24382@snarc.org \
--to=vincent.hanquez@cl.cam.ac.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncmike@us.ibm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox