Re: 2.6.16 - sys_sched_getaffinity & hotplug

[Jack Steiner <steiner@sgi.com>]

On Sat, Jan 28, 2006 at 02:32:44PM +0100, Ingo Molnar wrote:
> 
> * Paul Jackson <pj@sgi.com> wrote:
> 
> > Jack wrote:
> > > Should the following change be made to sched_getaffinity(). 
> > > 
> > > Index: linux/kernel/sched.c
> > > ===================================================================
> > > --- linux.orig/kernel/sched.c	2006-01-25 08:50:21.401747695 -0600
> > > +++ linux/kernel/sched.c	2006-01-27 16:57:24.504871895 -0600
> > > @@ -4031,7 +4031,7 @@ long sched_getaffinity(pid_t pid, cpumas
> > >  		goto out_unlock;
> > >  
> > >  	retval = 0;
> > > -	cpus_and(*mask, p->cpus_allowed, cpu_possible_map);
> > > +	cpus_and(*mask, p->cpus_allowed, cpu_online_map);
> > 
> > Adding Robert Love to the cc list, as he is Mr. sched_getaffinity, I 
> > believe.
> 
> i'm to blame for the syscall, Robert is to blame for the tool side
> :-) In any case, Jack's change looks reasonable and obviously correct.
> 
> Acked-by: Ingo Molnar <mingo@elte.hu>
> 
> 	Ingo

Ok, thanks. I'll repost as a patch later today....


-- 
Thanks

Jack Steiner (steiner@sgi.com)          651-683-5302