public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dipankar Sarma <dipankar@in.ibm.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org,
	"Paul E. McKenney" <paulmck@us.ibm.com>,
	Srivatsa Vaddagiri <vatsa@in.ibm.com>,
	Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] rcu_process_callbacks: don't cli() while testing ->nxtlist
Date: Sun, 29 Jan 2006 00:19:04 +0530	[thread overview]
Message-ID: <20060128184904.GF5633@in.ibm.com> (raw)
In-Reply-To: <43DBBFA9.8D5E231A@tv-sign.ru>

On Sat, Jan 28, 2006 at 10:02:01PM +0300, Oleg Nesterov wrote:
> __rcu_process_callbacks() disables interrupts to protect itself
> from call_rcu() which adds new entries to ->nxtlist.
> 
> However we can check "->nxtlist != NULL" with interrupts enabled,
> we can't get "false positives" because call_rcu() can only change
> this condition from 0 to 1.
> 
> Tested with rcutorture.ko.
> 
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

Looks good to me.

Thanks
Dipankar

      reply	other threads:[~2006-01-28 18:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-28 19:02 [PATCH] rcu_process_callbacks: don't cli() while testing ->nxtlist Oleg Nesterov
2006-01-28 18:49 ` Dipankar Sarma [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060128184904.GF5633@in.ibm.com \
    --to=dipankar@in.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=paulmck@us.ibm.com \
    --cc=torvalds@osdl.org \
    --cc=vatsa@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox