Re: [PATCH] iforce: fix -ENOMEM check

Re: [PATCH] iforce: fix -ENOMEM check

[Marek Vašut]

I have tried that patch, but nothing changed ...
That error is still there and no new device in /dev/input appears

Re: [PATCH] iforce: fix -ENOMEM check

[Dmitry Torokhov]

On Saturday 28 January 2006 13:03, Marek Vašut wrote:
> I have tried that patch, but nothing changed ...
> That error is still there and no new device in /dev/input appears

You do have updated udev, don't you? Could you pease post your dmesg
with the patch applied?

-- 
Dmitry

Re: [PATCH] iforce: fix -ENOMEM check

[Marek Vašut]

Dne neděle 29 ledna 2006 05:14 jste napsal(a):
> On Saturday 28 January 2006 13:03, Marek Vašut wrote:
> > I have tried that patch, but nothing changed ...
> > That error is still there and no new device in /dev/input appears
>
> You do have updated udev, don't you? Could you pease post your dmesg
> with the patch applied?

usb 4-2: new full speed USB device using uhci_hcd and address 2
usb 4-2: configuration #1 chosen from 1 choice
iforce-main.c: Timeout waiting for response from device.
usbcore: registered new driver iforce

I´ve cut off the unnecessary parts. This is what shows up when I connect it.
There is no js0 in /dev/input ... thats weird, isn´t it?

Re: [PATCH] iforce: fix -ENOMEM check

[Dmitry Torokhov]

On Sunday 29 January 2006 06:09, Marek Vašut wrote:
> Dne neděle 29 ledna 2006 05:14 jste napsal(a):
> > On Saturday 28 January 2006 13:03, Marek Vašut wrote:
> > > I have tried that patch, but nothing changed ...
> > > That error is still there and no new device in /dev/input appears
> >
> > You do have updated udev, don't you? Could you pease post your dmesg
> > with the patch applied?
> 
> usb 4-2: new full speed USB device using uhci_hcd and address 2
> usb 4-2: configuration #1 chosen from 1 choice
> iforce-main.c: Timeout waiting for response from device.
> usbcore: registered new driver iforce
> 
> I´ve cut off the unnecessary parts. This is what shows up when I connect it.
> There is no js0 in /dev/input ... thats weird, isn´t it?
> 

OK, the patch below should get it going... Please let me know if it makes
device appear.

-- 
Dmitry

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---

 drivers/input/joystick/iforce/iforce-packets.c |    4 ++--
 drivers/input/joystick/iforce/iforce-usb.c     |    1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

Index: work/drivers/input/joystick/iforce/iforce-packets.c
===================================================================
--- work.orig/drivers/input/joystick/iforce/iforce-packets.c
+++ work/drivers/input/joystick/iforce/iforce-packets.c
@@ -167,9 +167,9 @@ void iforce_process_packet(struct iforce
 		iforce->expect_packet = 0;
 		iforce->ecmd = cmd;
 		memcpy(iforce->edata, data, IFORCE_MAX_LENGTH);
-		wake_up(&iforce->wait);
 	}
 #endif
+	wake_up(&iforce->wait);
 
 	if (!iforce->type) {
 		being_used--;
@@ -264,7 +264,7 @@ int iforce_get_id_packet(struct iforce *
 		wait_event_interruptible_timeout(iforce->wait,
 			iforce->ctrl->status != -EINPROGRESS, HZ);
 
-		if (iforce->ctrl->status != -EINPROGRESS) {
+		if (iforce->ctrl->status) {
 			usb_unlink_urb(iforce->ctrl);
 			return -1;
 		}
Index: work/drivers/input/joystick/iforce/iforce-usb.c
===================================================================
--- work.orig/drivers/input/joystick/iforce/iforce-usb.c
+++ work/drivers/input/joystick/iforce/iforce-usb.c
@@ -95,7 +95,6 @@ static void iforce_usb_irq(struct urb *u
 		goto exit;
 	}
 
-	wake_up(&iforce->wait);
 	iforce_process_packet(iforce,
 		(iforce->data[0] << 8) | (urb->actual_length - 1), iforce->data + 1, regs);
 

Re: [PATCH] iforce: fix -ENOMEM check

[Marek Vašut]

Dne pondělí 30 ledna 2006 04:26 jste napsal(a):
> OK, the patch below should get it going... Please let me know if it makes
> device appear.
Yeah, it works :-)
Thanks a lot. Maybe this fix should get somehow in kernel tree.

Guillemot joystick not working since 2.6.14

[Marek Vašut]

Hi,
I found a problem with guillemot "force feedback joystick". It´s not working 
since 2.6.13.2-mm3. 2.6.14.2 wasn´t working too. 2.6.15-mm2 is the same. When 
I plug it in, it prints "configuration #1 chosen from 1 choice" "registered 
new driver iforce" and >"iforce: probe of 4-2:1.0 failed with error -12"<
It was working well on 2.6.13.1, but now it doesnt. I am not able to debug the 
kernel. Could you please fix this or tell me what am I doing wrong? Thanks.

Marex

Re: Guillemot joystick not working since 2.6.14

[Alexey Dobriyan]

On Sun, Jan 22, 2006 at 12:50:26PM +0100, Marek Va?ut wrote:
> I found a problem with guillemot "force feedback joystick". It?s not working
> since 2.6.13.2-mm3. 2.6.14.2 wasn?t working too. 2.6.15-mm2 is the same. When
> I plug it in, it prints "configuration #1 chosen from 1 choice" "registered
> new driver iforce" and >"iforce: probe of 4-2:1.0 failed with error -12"<
> It was working well on 2.6.13.1, but now it doesnt. I am not able to debug the 
> kernel. Could you please fix this or tell me what am I doing wrong? Thanks.

Please try this patch

--- a/drivers/input/joystick/iforce/iforce-main.c
+++ b/drivers/input/joystick/iforce/iforce-main.c
@@ -345,7 +345,7 @@ int iforce_init_device(struct iforce *if
 	int i;
 
 	input_dev = input_allocate_device();
-	if (input_dev)
+	if (!input_dev)
 		return -ENOMEM;
 
 	init_waitqueue_head(&iforce->wait);

Re: Guillemot joystick not working since 2.6.14

[Dmitry Torokhov]

On Sunday 22 January 2006 14:55, Alexey Dobriyan wrote:
> On Sun, Jan 22, 2006 at 12:50:26PM +0100, Marek Va?ut wrote:
> > I found a problem with guillemot "force feedback joystick". It?s not working
> > since 2.6.13.2-mm3. 2.6.14.2 wasn?t working too. 2.6.15-mm2 is the same. When
> > I plug it in, it prints "configuration #1 chosen from 1 choice" "registered
> > new driver iforce" and >"iforce: probe of 4-2:1.0 failed with error -12"<
> > It was working well on 2.6.13.1, but now it doesnt. I am not able to debug the 
> > kernel. Could you please fix this or tell me what am I doing wrong? Thanks.
> 
> Please try this patch
> 
> --- a/drivers/input/joystick/iforce/iforce-main.c
> +++ b/drivers/input/joystick/iforce/iforce-main.c
> @@ -345,7 +345,7 @@ int iforce_init_device(struct iforce *if
>  	int i;
>  
>  	input_dev = input_allocate_device();
> -	if (input_dev)
> +	if (!input_dev)
>  		return -ENOMEM;
>  
>  	init_waitqueue_head(&iforce->wait);
> 

Doh! Could you please add your signoff so I'd add it to the input tree?

Anyway, dynalloc went in 2.6.15 so something else is amiss...

-- 
Dmitry

[PATCH] iforce: fix -ENOMEM check

[Alexey Dobriyan]

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 drivers/input/joystick/iforce/iforce-main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/input/joystick/iforce/iforce-main.c
+++ b/drivers/input/joystick/iforce/iforce-main.c
@@ -345,7 +345,7 @@ int iforce_init_device(struct iforce *if
 	int i;
 
 	input_dev = input_allocate_device();
-	if (input_dev)
+	if (!input_dev)
 		return -ENOMEM;
 
 	init_waitqueue_head(&iforce->wait);

Re: [PATCH] iforce: fix -ENOMEM check

[Dmitry Torokhov]

On Monday 23 January 2006 10:28, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  drivers/input/joystick/iforce/iforce-main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/input/joystick/iforce/iforce-main.c
> +++ b/drivers/input/joystick/iforce/iforce-main.c
> @@ -345,7 +345,7 @@ int iforce_init_device(struct iforce *if
>  	int i;
>  
>  	input_dev = input_allocate_device();
> -	if (input_dev)
> +	if (!input_dev)
>  		return -ENOMEM;
>  
>  	init_waitqueue_head(&iforce->wait);
> 
> 

Applied to the input tree, thank you.

-- 
Dmitry