public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jack Steiner <steiner@sgi.com>
To: akpm@osdl.org
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: [PATCH] - sys_sched_getaffinity & hotplug
Date: Sun, 29 Jan 2006 07:51:04 -0600	[thread overview]
Message-ID: <20060129135104.GA19068@sgi.com> (raw)
In-Reply-To: <20060128120620.00be8227.pj@sgi.com>

Change sched_getaffinity() so that it returns a bitmap that indicates the
legally schedulable cpus that a task is allowed to run on. 

Without this patch, if CONFIG_HOTPLUG_CPU is enabled, sched_getaffinity()
unconditionally returns (at least on IA64) a mask with NR_CPUS bits set.
This conveys no useful infornmation except for a kernel compile option.


	Signed-off-by: Jack Steiner <steiner@sgi.com>
	Acked-by: Ingo Molnar <mingo@elte.hu>

---
This fixes a breakage we obseved running recent kernels. We have MPI jobs
that use sched_getaffinity() to determine where to place their threads. 
Placing them on non-existant cpus is problematic :-)


Index: linux/kernel/sched.c
===================================================================
--- linux.orig/kernel/sched.c	2006-01-28 10:13:01.834293691 -0600
+++ linux/kernel/sched.c	2006-01-29 07:15:11.217227453 -0600
@@ -4031,7 +4031,7 @@ long sched_getaffinity(pid_t pid, cpumas
 		goto out_unlock;
 
 	retval = 0;
-	cpus_and(*mask, p->cpus_allowed, cpu_possible_map);
+	cpus_and(*mask, p->cpus_allowed, cpu_online_map);
 
 out_unlock:
 	read_unlock(&tasklist_lock);

  reply	other threads:[~2006-01-29 13:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-27 23:06 2.6.16 - sys_sched_getaffinity & hotplug Jack Steiner
2006-01-28  2:58 ` Nathan Lynch
2006-01-29 13:06   ` Jack Steiner
2006-01-28  3:14 ` Paul Jackson
2006-01-28  3:42   ` Nathan Lynch
2006-01-28  4:58     ` Paul Jackson
2006-01-28  5:23       ` Nathan Lynch
2006-01-28  6:40         ` Paul Jackson
2006-01-28  7:04         ` Paul Jackson
2006-01-28 13:32   ` Ingo Molnar
2006-01-28 16:08     ` Jack Steiner
2006-01-28 19:27     ` Nathan Lynch
2006-01-28 20:06       ` Paul Jackson
2006-01-29 13:51         ` Jack Steiner [this message]
2006-01-28 20:09     ` Paul Jackson
2006-01-28 20:50       ` Robert Love
2006-01-28 21:00         ` Paul Jackson
2006-01-29 13:01         ` Ingo Molnar
2006-01-29 16:09           ` Robert Love
2006-01-29 17:26             ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060129135104.GA19068@sgi.com \
    --to=steiner@sgi.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox