From: "Ville Syrjälä" <syrjala@sci.fi>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Andrew Morton <akpm@osdl.org>, Ingo Oeser <ioe-lkml@rameria.de>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
benh@kernel.crashing.org, linux-kernel@hansmi.ch
Subject: Re: [Linux-fbdev-devel] [PATCH] fbdev: Fix usage of blank value passed to fb_blank
Date: Sun, 29 Jan 2006 16:42:28 +0200 [thread overview]
Message-ID: <20060129144228.GA22425@sci.fi> (raw)
In-Reply-To: <43DC25EB.1040005@gmail.com>
On Sun, Jan 29, 2006 at 10:18:19AM +0800, Antonino A. Daplas wrote:
> diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
> index d2dede6..5bed0fb 100644
> --- a/drivers/video/fbmem.c
> +++ b/drivers/video/fbmem.c
> @@ -843,6 +843,19 @@ fb_blank(struct fb_info *info, int blank
> {
> int ret = -EINVAL;
>
> + /*
> + * The framebuffer core supports 5 blanking levels (FB_BLANK), whereas
> + * VESA defined only 4. The extra level, FB_BLANK_NORMAL, is a
> + * console invention and is not related to power management.
> + * Unfortunately, fb_blank callers, especially X, pass VESA constants
> + * leading to undefined behavior.
Since when? X.Org uses numbers 0,2,3,4 which match the FB_BLANK
constants not the VESA constants.
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
next prev parent reply other threads:[~2006-01-29 14:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 23:13 [PATCH] framebuffer: Remove old radeon driver Michael Hanselmann
2006-01-28 4:09 ` Benjamin Herrenschmidt
2006-01-28 4:46 ` David S. Miller
2006-01-28 5:59 ` Antonino A. Daplas
2006-01-28 20:06 ` Ingo Oeser
2006-01-29 2:18 ` [PATCH] fbdev: Fix usage of blank value passed to fb_blank Antonino A. Daplas
2006-01-29 8:18 ` Andrew Morton
2006-01-29 10:40 ` Antonino A. Daplas
2006-01-29 14:42 ` Ville Syrjälä [this message]
2006-01-29 22:19 ` [Linux-fbdev-devel] " Antonino A. Daplas
2006-01-29 23:34 ` Antonino A. Daplas
2006-01-30 10:22 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060129144228.GA22425@sci.fi \
--to=syrjala@sci.fi \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=ioe-lkml@rameria.de \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@hansmi.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox