From: Pavel Machek <pavel@ucw.cz>
To: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Make software suspend work with CONFIG_MEMORY_HOTPLUG=n
Date: Sun, 29 Jan 2006 16:15:10 +0100 [thread overview]
Message-ID: <20060129151509.GC1764@elf.ucw.cz> (raw)
In-Reply-To: <20060127204315.GA30447@redhat.com>
Hi!
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178339
>
> pageset_cpuup_callback() is marked __meminit, but software suspend
> needs it. Unfortunatly, if you don't have CONFIG_MEMORY_HOTPLUG set,
> the __meminit translates to __init, resulting in this...
> Signed-off-by: Dave Jones <davej@redhat.com>
ACK. Please push...
Pavel
> --- linux-2.6.15.noarch/mm/page_alloc.c~ 2006-01-27 15:40:35.000000000 -0500
> +++ linux-2.6.15.noarch/mm/page_alloc.c 2006-01-27 15:40:40.000000000 -0500
> @@ -1939,7 +1939,7 @@ static inline void free_zone_pagesets(in
> }
> }
>
> -static int __meminit pageset_cpuup_callback(struct notifier_block *nfb,
> +static int pageset_cpuup_callback(struct notifier_block *nfb,
> unsigned long action,
> void *hcpu)
> {
--
Thanks, Sharp!
prev parent reply other threads:[~2006-01-29 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 20:43 Make software suspend work with CONFIG_MEMORY_HOTPLUG=n Dave Jones
2006-01-29 15:15 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060129151509.GC1764@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox