From: Andi Kleen <ak@suse.de>
To: Muli Ben-Yehuda <mulix@mulix.org>
Cc: Andrew Morton <akpm@osdl.org>, Jon Mason <jdmason@us.ibm.com>,
Christoph Hellwig <hch@lst.de>,
"Luck, Tony" <tony.luck@intel.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
Muli Ben-Yehuda <MULI@il.ibm.com>
Subject: Re: [PATCH RESEND] move swiotlb.h header file to asm-generic
Date: Mon, 30 Jan 2006 10:49:41 +0100 [thread overview]
Message-ID: <200601301049.41854.ak@suse.de> (raw)
In-Reply-To: <20060130094434.GG23968@granada.merseine.nu>
On Monday 30 January 2006 10:44, Muli Ben-Yehuda wrote:
> This patch:
>
> - creates asm-generic/swiotlb.h
> - makes it use 'enum dma_data_direction dir' rather than 'int dir'
> - updates x86-64 and IA64 to use the common swiotlb.h
> - fixes the resulting fall out (s/int dir/enum dma_data_direction dir/
> all over the place).
Al Viro will likely flame you badly for that enum change. Apparently it
causes some trouble in sparse. Frankly i don't see the point neither.
It just makes the code harder to read and creates a monstrosity of a patch
and doesn't give you anything.
-Andi
>
next prev parent reply other threads:[~2006-01-30 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-30 9:44 [PATCH RESEND] move swiotlb.h header file to asm-generic Muli Ben-Yehuda
2006-01-30 9:49 ` Andi Kleen [this message]
2006-01-30 10:01 ` Muli Ben-Yehuda
2006-01-30 10:08 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601301049.41854.ak@suse.de \
--to=ak@suse.de \
--cc=MULI@il.ibm.com \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=jdmason@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mulix@mulix.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox