From: Jan Blunck <jblunck@suse.de>
To: Kirill Korotaev <dev@sw.ru>
Cc: Balbir Singh <balbir@in.ibm.com>,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@osdl.org>,
olh@suse.de
Subject: Re: [PATCH] shrink_dcache_parent() races against shrink_dcache_memory()
Date: Mon, 30 Jan 2006 16:25:15 +0100 [thread overview]
Message-ID: <20060130152515.GH9181@hasse.suse.de> (raw)
In-Reply-To: <43DE2A71.80906@sw.ru>
On Mon, Jan 30, Kirill Korotaev wrote:
> >>We can think about optimizing this to
> >> if (!sb->sprunes)
> >> wake_up(&sb->s_wait_prunes);
> >>
> >
> >
> >Hardly. This is only the case when two or more shrinkers are active in
> >parallel. If that was the case often, we would have seen this much more
> >frequent IMHO.
> But this avoids taking 2nd lock on fast path.
>
No, the fast path (more frequent) is s_prunes == 0.
sb->s_prunes--;
if (likely(!sb->s_prunes))
wake_up(&sb->s_wait_prunes);
This is only optimizing a rare case ... and unmounting isn't very time
critical.
Regards,
Jan
--
Jan Blunck jblunck@suse.de
SuSE LINUX AG - A Novell company
Maxfeldstr. 5 +49-911-74053-608
D-90409 Nürnberg http://www.suse.de
next prev parent reply other threads:[~2006-01-30 15:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 20:36 [PATCH] shrink_dcache_parent() races against shrink_dcache_memory() Jan Blunck
2006-01-23 5:22 ` Andrew Morton
2006-01-23 8:12 ` Kirill Korotaev
2006-01-23 15:13 ` Jan Blunck
2006-01-23 8:07 ` Kirill Korotaev
2006-01-23 15:57 ` Jan Blunck
2006-01-24 5:54 ` Balbir Singh
2006-01-24 9:48 ` Kirill Korotaev
2006-01-24 11:10 ` Balbir Singh
2006-01-24 17:18 ` Kirill Korotaev
2006-01-25 7:03 ` Balbir Singh
2006-01-30 12:03 ` Jan Blunck
2006-01-30 14:38 ` Balbir Singh
2006-01-30 14:54 ` Jan Blunck
2006-01-30 15:02 ` Kirill Korotaev
2006-01-30 15:25 ` Jan Blunck [this message]
2006-01-30 15:31 ` Kirill Korotaev
2006-01-30 14:42 ` Kirill Korotaev
2006-01-30 14:58 ` Jan Blunck
2006-01-30 15:59 ` Kirill Korotaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060130152515.GH9181@hasse.suse.de \
--to=jblunck@suse.de \
--cc=akpm@osdl.org \
--cc=balbir@in.ibm.com \
--cc=dev@sw.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox