From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1030337AbWBAFeJ@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1030337AbWBAFeJ (ORCPT <rfc822;willy@w.ods.org>);
	Wed, 1 Feb 2006 00:34:09 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030345AbWBAFeJ
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 1 Feb 2006 00:34:09 -0500
Received: from mx1.redhat.com ([66.187.233.31]:24763 "EHLO mx1.redhat.com")
	by vger.kernel.org with ESMTP id S1030337AbWBAFeI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Feb 2006 00:34:08 -0500
Date: Wed, 1 Feb 2006 00:33:57 -0500
From: Dave Jones <davej@redhat.com>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: Andrew Morton <akpm@osdl.org>, Ashok Raj <ashok.raj@intel.com>,
       linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch -mm4] i386: __init should be __cpuinit
Message-ID: <20060201053357.GA5335@redhat.com>
Mail-Followup-To: Dave Jones <davej@redhat.com>,
	Chuck Ebbert <76306.1226@compuserve.com>,
	Andrew Morton <akpm@osdl.org>, Ashok Raj <ashok.raj@intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
References: <200601312352_MC3-1-B748-FCE9@compuserve.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200601312352_MC3-1-B748-FCE9@compuserve.com>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 31, 2006 at 11:49:43PM -0500, Chuck Ebbert wrote:
 > When CONFIG_HOTPLUG_CPU on i386 there are places where __init[data] is
 > referenced from normal code.
 > 
 > On startup:
 >         arch/i386/kernel/cpu/amd.c::amd_init_cpu():
 >                 cpu_devs[X86_VENDOR_AMD] = &amd_cpu_dev;        
 >         amd_cpu_dev is declared __initdata and is freed
 > 
 > On CPU hotplug:
 >         arch/i386/kernel/cpu/common.c::get_cpu_vendor():
 >                for (i = 0; i < X86_VENDOR_NUM; i++) {
 >                         if (cpu_devs[i]) {
 >                                 if (!strcmp(v,cpu_devs[i]->c_ident[0]) ||
 > 
 > To fix this, change every instance of __init that seems suspicious
 > into __cpuinit.  When !CONFIG_HOTPLUG_CPU there is no change in .text
 > or .data size.  When enabled, .text += 3248 bytes; .data += 2148 bytes.
 > 
 > This should be safe in every case; the only drawback is the extra code and
 > data when CPU hotplug is enabled.

Especially as for the bulk of them, those CPUs aren't hotplug capable.
(I seriously doubt we'll ever see a hotplugable cyrix for eg, which
 takes up the bulk of your diff).

How about leaving it __init on non-hotplug systems, and somehow removing
those from cpu_devs, so get_cpu_vendor() just skips them ?
NULL'ing those entries should be just a few bytes, instead of adding 5KB.

		Dave