From: Greg KH <greg@kroah.com>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/11] LED: Add LED device support for the zaurus corgi and spitz models
Date: Tue, 31 Jan 2006 21:54:16 -0800 [thread overview]
Message-ID: <20060201055416.GA23520@kroah.com> (raw)
In-Reply-To: <1138714903.6869.132.camel@localhost.localdomain>
On Tue, Jan 31, 2006 at 01:41:43PM +0000, Richard Purdie wrote:
> Adds LED drivers for LEDs found on the Sharp Zaurus c7x0 (corgi,
> shepherd, husky) and cxx00 (akita, spitz, borzoi) models.
>
> Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
>
> Index: linux-2.6.15/arch/arm/mach-pxa/corgi.c
> ===================================================================
> --- linux-2.6.15.orig/arch/arm/mach-pxa/corgi.c 2006-01-29 16:02:30.000000000 +0000
> +++ linux-2.6.15/arch/arm/mach-pxa/corgi.c 2006-01-29 16:11:47.000000000 +0000
> @@ -165,6 +165,15 @@
>
>
> /*
> + * Corgi LEDs
> + */
> +static struct platform_device corgiled_device = {
> + .name = "corgi-led",
> + .id = -1,
> +};
Please use the platform device interface to create these dynamically and
don't make static structures.
thanks,
greg k-h
next prev parent reply other threads:[~2006-02-01 5:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 13:41 [PATCH 6/11] LED: Add LED device support for the zaurus corgi and spitz models Richard Purdie
2006-02-01 5:54 ` Greg KH [this message]
2006-02-01 8:50 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060201055416.GA23520@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox