public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@us.ibm.com>
To: Linus Torvalds <torvalds@osdl.org>,
	linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] rcu: undeclared variable used in documentation
Date: Wed, 1 Feb 2006 20:02:03 -0800	[thread overview]
Message-ID: <20060202040203.GA27243@us.ibm.com> (raw)
In-Reply-To: <20060131010043.GA17021@ev-en.org>

On Tue, Jan 31, 2006 at 03:00:43AM +0200, Baruch Even wrote:
> 
> The RCU documentation uses an fp variable which is not declared in the code
> snippets. Use the new_fp variable instead.

Good catch!!!

							Thanx, Paul

Acked-by: <paulmck@us.ibm.com>
> Signed-Off-By: Baruch Even <baruch@ev-en.org>
> ---
> 
>  Documentation/RCU/whatisRCU.txt |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: htcp-abc/Documentation/RCU/whatisRCU.txt
> ===================================================================
> --- htcp-abc.orig/Documentation/RCU/whatisRCU.txt
> +++ htcp-abc/Documentation/RCU/whatisRCU.txt
> @@ -357,7 +357,7 @@ uses of RCU may be found in listRCU.txt,
>  		struct foo *new_fp;
>  		struct foo *old_fp;
>  
> -		new_fp = kmalloc(sizeof(*fp), GFP_KERNEL);
> +		new_fp = kmalloc(sizeof(*new_fp), GFP_KERNEL);
>  		spin_lock(&foo_mutex);
>  		old_fp = gbl_foo;
>  		*new_fp = *old_fp;
> @@ -456,7 +456,7 @@ The foo_update_a() function might then b
>  		struct foo *new_fp;
>  		struct foo *old_fp;
>  
> -		new_fp = kmalloc(sizeof(*fp), GFP_KERNEL);
> +		new_fp = kmalloc(sizeof(*new_fp), GFP_KERNEL);
>  		spin_lock(&foo_mutex);
>  		old_fp = gbl_foo;
>  		*new_fp = *old_fp;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
> 

      reply	other threads:[~2006-02-02  4:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-31  1:00 [PATCH] rcu: undeclared variable used in documentation Baruch Even
2006-02-02  4:02 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060202040203.GA27243@us.ibm.com \
    --to=paulmck@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox