From: Chuck Ebbert <76306.1226@compuserve.com>
To: Neil Brown <neilb@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, Gerd Hoffman <kraxel@suse.de>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.16-rc1-mm4 i386 atomic operations broken on SMP (in modules at least)
Date: Thu, 2 Feb 2006 13:12:37 -0500 [thread overview]
Message-ID: <200602021314_MC3-1-B765-7FAF@compuserve.com> (raw)
In-Reply-To: <17377.24090.486443.865483@cse.unsw.edu.au>
On Thu, 2 Feb 2006 at 12:19:22 +1100, Neil Brown wrote:
> My guess is there is there is something wrong with the 'alternative'
> stuff which strips out the lock prefix, but I couldn't see anything
> obviously wrong. The CPUs don't have FEATURE_UP (see below) so it
> cannot possibly be removing the 'lock' prefix... but it certainly acts
> like it is.
Look closer:
> flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca
> cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe lm
> constant_tsc pni monitor ds_cpl cid xtpr
^^^^^^^^^^^^
SMP alternatives is re-using the constant_tsc X86 feature bit.
--- 2.6.16-rc1-mm4-386.orig/include/asm-i386/cpufeature.h
+++ 2.6.16-rc1-mm4-386/include/asm-i386/cpufeature.h
@@ -71,7 +71,7 @@
#define X86_FEATURE_P4 (3*32+ 7) /* P4 */
#define X86_FEATURE_CONSTANT_TSC (3*32+ 8) /* TSC ticks at a constant rate */
-#define X86_FEATURE_UP (3*32+ 8) /* smp kernel running on up */
+#define X86_FEATURE_UP (3*32+ 9) /* smp kernel running on up */
/* Intel-defined CPU features, CPUID level 0x00000001 (ecx), word 4 */
#define X86_FEATURE_XMM3 (4*32+ 0) /* Streaming SIMD Extensions-3 */
--
Chuck
next reply other threads:[~2006-02-02 18:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-02 18:12 Chuck Ebbert [this message]
2006-02-02 21:52 ` 2.6.16-rc1-mm4 i386 atomic operations broken on SMP (in modules at least) Andrew Morton
2006-02-02 22:41 ` Neil Brown
-- strict thread matches above, loose matches on Subject: below --
2006-02-02 23:28 Chuck Ebbert
2006-02-02 1:19 Neil Brown
2006-02-02 1:35 ` J.A. Magallon
2006-02-02 1:50 ` Neil Brown
2006-02-02 8:15 ` J.A. Magallon
2006-02-02 8:23 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602021314_MC3-1-B765-7FAF@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=kraxel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox