From: Chuck Ebbert <76306.1226@compuserve.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, kraxel@suse.de, neilb@suse.de
Subject: Re: 2.6.16-rc1-mm4 i386 atomic operations broken on SMP (in modules at least)
Date: Thu, 2 Feb 2006 18:28:17 -0500 [thread overview]
Message-ID: <200602021830_MC3-1-B773-597F@compuserve.com> (raw)
In-Reply-To: <20060202135205.08d91b76.akpm@osdl.org>
On Thu, 2 Feb 2006 at 13:52:05 -0800, Andrew Morton wrote:
> Chuck Ebbert <76306.1226@compuserve.com> wrote:
> >
> > SMP alternatives is re-using the constant_tsc X86 feature bit.
> >
>
> Darn, how did you spot that?
I went looking for which bit represented X86_FEATURE_UP and there
it was...
>
> Should `feature_up' appear in /proc/cpuinfo?
Probably. The bug would have been nearly impossible if that had
been done to begin with.
i386: show x86 feature "up" in cpuinfo
Show feature bit "up" (SMP kernel running on uniprocessor) in
/proc/cpuinfo.
Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
--- 2.6.16-rc1-mm4-386.orig/arch/i386/kernel/cpu/proc.c
+++ 2.6.16-rc1-mm4-386/arch/i386/kernel/cpu/proc.c
@@ -40,7 +40,7 @@ static int show_cpuinfo(struct seq_file
/* Other (Linux-defined) */
"cxmmx", "k6_mtrr", "cyrix_arr", "centaur_mcr",
NULL, NULL, NULL, NULL,
- "constant_tsc", NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ "constant_tsc", "up", NULL, NULL, NULL, NULL, NULL, NULL,
NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
--
Chuck
next reply other threads:[~2006-02-02 23:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-02 23:28 Chuck Ebbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-02-02 18:12 2.6.16-rc1-mm4 i386 atomic operations broken on SMP (in modules at least) Chuck Ebbert
2006-02-02 21:52 ` Andrew Morton
2006-02-02 22:41 ` Neil Brown
2006-02-02 1:19 Neil Brown
2006-02-02 1:35 ` J.A. Magallon
2006-02-02 1:50 ` Neil Brown
2006-02-02 8:15 ` J.A. Magallon
2006-02-02 8:23 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602021830_MC3-1-B773-597F@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=kraxel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox