* 2.6.16-rc1-mm5
@ 2006-02-03 8:07 Andrew Morton
2006-02-03 10:17 ` 2.6.16-rc1-mm5 Benoit Boissinot
` (9 more replies)
0 siblings, 10 replies; 25+ messages in thread
From: Andrew Morton @ 2006-02-03 8:07 UTC (permalink / raw)
To: linux-kernel
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.6.16-rc1-mm5/
- The ntp/time rework patches from John Stultz have been resurrected and fixed.
- There's now a `hot-fixes' directory at the above URL. Please look in
there for any updates which should be applied.
Known problems:
- Sam has added a new check in the kbuild tree. It detects multiple
instances of EXPORT_SYMBOL(foo) across separate .o files.
It catches a _lot_ of problems. You'll see something like this:
WARNING: vmlinux: duplicate symbol '__down_interruptible' previous definition was in vmlinux
WARNING: vmlinux: duplicate symbol '__down' previous definition was in vmlinux
WARNING: vmlinux: duplicate symbol '__up' previous definition was in vmlinux
WARNING: vmlinux: duplicate symbol 'smp_call_function' previous definition was in vmlinux
WARNING: vmlinux: duplicate symbol 'iounmap' previous definition was in vmlinux
WARNING: vmlinux: duplicate symbol '__ioremap' previous definition was in vmlinux
WARNING: vmlinux: duplicate symbol 'ioremap' previous definition was in vmlinux
WARNING: vmlinux: duplicate symbol 'sys_ctrler' previous definition was in vmlinux
There's probably not a lot of point in reporting this if you see it.
Patches would be nice, but be warned that fixing these is not as trivial
as one might think:
- If one export is in generic code and the other is in arch code then
- If you remove the export in generic code, you need to check all
architectures for breakage.
- If you remove the export in arch code then you need to be sure
that the generic .o file a) always compiles in the offending function
and b) is always linked into vmlinux.
- If both exports are in arch code then you need to ensure that
the export which isn't deleted is always included in vmlinux when
the symbol which it exports is included in vmlinux.
If possible, the best approach is to put the EXPORT_SYMBOL
immediately after the symbol which is being exported. And if it's
a function, pleeeze don't put a blank line between the end of the
function and the export - I've no idea why people do that...
Boilerplate:
- -mm kernel commit activity can be reviewed by subscribing to the
mm-commits mailing list.
echo "subscribe mm-commits" | mail majordomo@vger.kernel.org
- If you hit a bug in -mm and it's not obvious which patch caused it, it is
most valuable if you can perform a bisection search to identify which patch
introduced the bug. Instructions for this process are at
http://www.zip.com.au/~akpm/linux/patches/stuff/bisecting-mm-trees.txt
But beware that this process takes some time (around ten rebuilds and
reboots), so consider reporting the bug first and if we cannot immediately
identify the faulty patch, then perform the bisection search.
- When reporting bugs, please try to Cc: the relevant maintainer and mailing
list on any email.
Changes since 2.6.15-mm4:
linus.patch
git-alsa.patch
git-arm.patch
git-audit.patch
git-blktrace.patch
git-block.patch
git-cfq.patch
git-cpufreq.patch
git-dvb.patch
git-ia64.patch
git-ieee1394.patch
git-infiniband.patch
git-jfs.patch
git-kbuild.patch
git-libata-all.patch
git-mmc.patch
git-netdev-all.patch
git-net.patch
git-nfs.patch
git-ntfs.patch
git-ocfs2.patch
git-parisc.patch
git-powerpc.patch
git-serial.patch
git-sym2.patch
git-pcmcia.patch
git-sas-jg.patch
git-watchdog.patch
git-cryptodev.patch
Git trees
-x86_64-compat_sys_futimesat-fix.patch
-config_isa-does-not-make-sense-for-config_ppc_pseries.patch
-prototypes-for-at-functions-typo-fix.patch
-knfsd-restore-recently-broken-acl-functionality-to-nfs-server.patch
-config_doublefault-kconfig-fix.patch -smbfs-readdir-vs-signal-fix.patch
-fuse-fix-async-read-for-legacy-filesystems.patch -sound-ppc-pmacc-typo.patch
-__cpuinit-functions-wrongly-marked-__meminit.patch
-wrongly-marked-__init-__initdata-for-cpu-hotplug.patch
-ide-scsi-fix-for-ide-probe-remove-ops-changes.patch
-powerpc-enable-irqs-for-platform-functions.patch
-tsunami_flash-fix-parse-error-before-token.patch
-lp486e-remove-slow_down_io.patch
-ipw2100-add-generic-geo-information-to-be-compliant-with-ieee80211-117-changes.patch
-move-timespec-validation-into-do_settimeofday.patch
-compat_sys_pselect7-fix.patch
-device-mapper-snapshot-load-metadata-on-creation.patch
-device-mapper-log-bitset-fix-endian.patch
-device-mapper-ioctl-reduce-pf_memalloc-usage.patch
-device-mapper-statistics-basic.patch
-device-mapper-disk-statistics-timing.patch
-device-mapper-snapshot-barriers-not-supported.patch
-dm-dm-table-warning-fix.patch -seclvl_settime-fix.patch
-alpha-dma-mappingh-add-struct-scatterlist.patch
-ipw2200-fix-eeprom-check.patch
-ipmi-remove-invalid-acpi-register-spacing-check.patch
-tpm_infineon-fix-printk-format-warning.patch
-tpm_bios-needs-more-securityfs_-functions.patch
-tpm_bios-securityfs-error-checking-fix.patch -tpm_bios-indexing-fix.patch
-tpm-tpm-bios-fix-module-license-issue.patch
-tpm-tpm_bios-fix-sparse-warnings.patch
-tpm-tpm_bios-remove-unused-variable.patch
-mips-gdb-stubc-fix-parse-error-before-token.patch
-uml-compilation-fix-when-mode_skas-disabled.patch
-git-blktrace-sparc64-fix.patch -git-block-revert-stuff.patch
-sem2mutex-drivers-char-drm.patch
-drivers-char-drm-make-some-functions-static.patch
-ipw2100_match_buf-warning-fix.patch
-ipw2200-stack-reduction.patch
-tweak-orinoco_cs-debugging-message.patch
-revert-NET-Do-not-lose-accepted-socket-when-ENFILE-EMFILE.patch
-sem2mutex-ipw2x00.patch
-af_key-set-message-type.patch
-sungem-make-pm-of-phys-more-reliable-2.patch
-net-do-not-export-inet_bind_bucket_create-twice.patch
-serial-initialize-spinlock-for-port-failed-to-setup.patch
-gregkh-pci-pci-schedule-pci_legacy_proc-for-removal.patch
-gregkh-pci-pci-schedule-removal-of-pci_module_init.patch
-gregkh-pci-pci-irq-and-pci_ids-patch-for-intel-ich8.patch
-gregkh-pci-pci-drivers-pci-pci.c-if-0-pci_find_ext_capability.patch
-gregkh-pci-pci-make-it-easier-to-see-that-set_msi_affinity-is-used.patch
-gregkh-pci-pci-hotplug-fix-up-coding-style-issues.patch
-gregkh-pci-pci-hotplug-fix-up-kconfig-help-text.patch
-gregkh-pci-pci-restore-2-missing-pci-ids.patch
-gregkh-pci-pci-pci_ids-remove-duplicates-gathered-during-merge-period.patch
-gregkh-pci-pci-hotplug-powerpc-module-build-break.patch
-gregkh-pci-pci-hotplug-pci-panic-on-dlpar-add.patch
-gregkh-pci-pci-hotplug-shpchp-amd-pogo-errata-fix.patch
-gregkh-pci-powerpc-pci-hotplug-remove-rpaphp_find_bus.patch
-gregkh-pci-powerpc-pci-hotplug-remove-rpaphp_fixup_new_pci_devices.patch
-gregkh-pci-powerpc-pci-hotplug-merge-config_pci_adapter.patch
-gregkh-pci-powerpc-pci-hotplug-remove-remove_bus_device.patch
-gregkh-pci-powerpc-pci-hotplug-de-convolute-rpaphp_unconfig_pci_adap.patch
-gregkh-pci-powerpc-pci-hotplug-merge-rpaphp_enable_pci_slot.patch
-gregkh-pci-powerpc-pci-hotplug-cleanup-add-prefix.patch
-gregkh-pci-powerpc-pci-hotplug-minor-cleanup-forward-decls.patch
-gregkh-pci-powerpc-pci-hotplug-shuffle-error-checking-to-better-location.patch
-gregkh-pci-pci-cyblafb-remove-pci_module_init-return-really.patch
-gregkh-pci-pci-handle-bogus-mcfg-entries.patch
-gregkh-pci-msi-vector-targeting-abstractions.patch
-gregkh-pci-altix-msi-support.patch
-gregkh-pci-pci-fix-msi-build-breakage-in-x86_64.patch
-gregkh-pci-pci-clean-up-msi.c-a-bit.patch
-fusion-update.patch
-fusion-unloading-the-driver-results-in-panic-fix.patch
-fusion-unloading-the-driver-only-set-asyn-narrow-for-configured-devices.patch
-fusion-sanity-check.patch
-fusion-add-support-for-raid-hot-add-del-support.patch
-fusion-target-reset-when-drive-is-being-removed.patch
-fusion-move-sas-persistent-event-handling-over-to-the-mptsas-module.patch
-fusion-fc-rport-code-fixes.patch
-fusion-bump-version.patch
-gregkh-usb-usb-fix-ehci-early-handoff-issues.patch
-gregkh-usb-usb-fix-ehci-early-handoff-issues-warning.patch
-gregkh-usb-usb-ub-03-oops-with-cfq.patch
-gregkh-usb-usb-ub-04-loss-of-timer-and-a-hang.patch
-gregkh-usb-usb-ub-05-bulk-reset.patch
-gregkh-usb-usb-new-id-for-ftdi_sio.c-and-ftdi_sio.h.patch
-gregkh-usb-usb-ftdi_sio-new-ids-for-westrex-devices.patch
-gregkh-usb-usb-ftdi_sio-new-pid-for-pcdj-dac2.patch
-gregkh-usb-ftdi-two-new-atik-based-usb-astronomical-ccd-cameras.patch
-gregkh-usb-usb-yealink.c-cleanup-device-matching-code.patch
-gregkh-usb-usb-usb-storage-add-support-for-rio-karma.patch
-gregkh-usb-usb-cleanup-of-usblp.patch
-gregkh-usb-usb-fix-oops-in-acm-disconnect.patch
-gregkh-usb-usb-usb-storage-support-for-sony-dsc-t5-still-camera.patch
-gregkh-usb-usb-sn9c10x-driver-updates-and-bugfixes.patch
-gregkh-usb-usb-asix-add-device-ids-for-0g0-cable-ethernet.patch
-gregkh-usb-usb-touchkitusb.c-fix.patch
-gregkh-usb-usb-pl2303-added-support-for-ca-42-clone-cable.patch
-gregkh-usb-usb-add-new-pl2303-device-ids.patch
-gregkh-usb-usb-cp2101-add-new-device-ids.patch
-gregkh-usb-usb-sn9c10x-driver-updates.patch
-gregkh-usb-usb-add-et61x51-video4linux2-driver.patch
-gregkh-usb-usbatm-trivial-modifications.patch
-gregkh-usb-usbatm-add-flags-field.patch
-gregkh-usb-usbatm-remove-.owner.patch
-gregkh-usb-usbatm-kzalloc-conversion.patch
-gregkh-usb-usbatm-xusbatm-rewrite.patch
-gregkh-usb-usbatm-shutdown-open-connections-when-disconnected.patch
-gregkh-usb-usbatm-return-correct-error-code-when-out-of-memory.patch
-gregkh-usb-usbatm-use-dev_kfree_skb_any-rather-than-dev_kfree_skb.patch
-gregkh-usb-usbatm-measure-buffer-size-in-bytes-force-valid-sizes.patch
-gregkh-usb-usbatm-allow-isochronous-transfer.patch
-gregkh-usb-usbatm-handle-urbs-containing-partial-cells.patch
-gregkh-usb-usbatm-bump-version-numbers.patch
-gregkh-usb-usbatm-eilseq-workaround.patch
-gregkh-usb-usbatm-semaphore-to-mutex-conversion.patch
-gregkh-usb-ueagle-add-iso-support.patch
-gregkh-usb-ueagle-cosmetic.patch
-gregkh-usb-ueagle-cmv-name-bug.patch
-gregkh-usb-usb-add-new-auerswald-device-ids.patch
-gregkh-usb-usb-hid-add-blacklist-entry-for-hp-keyboard.patch
-gregkh-usb-usb-ehci-another-full-speed-iso-fix.patch
-gregkh-usb-usb-uhci-no-fsbr-until-device-is-configured.patch
-gregkh-usb-usb-remove-misc-devfs-droppings.patch
-gregkh-usb-usb-net2280-warning-fix.patch
-gregkh-usb-add-might_sleep-to-usb_unlink_urb.patch
-gregkh-usb-usb-isp116x-hcd-replace-mdelay-by-msleep.patch
-gregkh-usb-usb-gadgetfs-set-zero-flag-for-short-control-in-response.patch
-gregkh-usb-usb-remove-linux_version_code-check-in-pwc-pwc-ctrl.c.patch
-gregkh-usb-usb-ehci-fix-gfp_t-sparse-warning.patch
-gregkh-usb-usb-drivers-usb-media-w9968cf.c-remove-hooks-for-the-vpp-module.patch
-gregkh-usb-usb-drivers-usb-media-ov511.c-remove-hooks-for-the-decomp-module.patch
-gregkh-usb-usb-remove-extra-newline-in-hid_init_reports.patch
-gregkh-usb-usb-au1xx0-replace-casual-readl-with-au_readl-in-the-drivers.patch
-gregkh-usb-usb-arm26-fix-compilation-of-drivers-usb-core-message.c.patch
-gregkh-usb-usb-libusual-fix-warning-on-64bit-boxes.patch
-gregkh-usb-usb-yealink-printk-warning-fix.patch
-gregkh-usb-usb-usb-authentication-states.patch
-gregkh-usb-usb-gadget-zero-and-dma-coherent-buffers.patch
-hrtimers-fixup-itimer-conversion.patch
-hrtimers-fix-possible-use-of-null-pointer-in.patch
-hrtimers-fix-oldvalue-return-in-setitimer.patch
-hrtimers-fix-posix-timer-requeue-race.patch
-hrtimers-cleanups-and-simplifications.patch
-hrtimers-add-back-lost-credit-lines.patch
-hrtimers-set-correct-initial-expiry-time-for-relative.patch
-hrtimers-set-correct-initial-expiry-time-for-relative-fix.patch
-kernel-posix-timersc-remove-do_posix_clock_notimer_create.patch
-fix-deadlock-in-drivers-pci-msic.patch
-fix-uidhash_lock-rcu-deadlock.patch
-fix-uidhash_lock-rcu-deadlock-fix.patch
-rcu_torture_lock-deadlock-fix.patch
-optimize-off-node-performance-of-zone-reclaim.patch
-zone_reclaim-reclaim-on-memory-only-node-support.patch
-zone_reclaim-reclaim-on-memory-only-node-support-fix.patch
-zone_reclaim-reclaim-on-memory-only-node-support-fix-tidy.patch
-gfp_zonetypes-add-commentry-on-how-to-calculate.patch
-gfp_zonetypes-calculate-from-gfp_zonemask.patch
-mm-improve-function-of-sc-may_writepage.patch
-zone_reclaim-minor-fixes.patch
-use-32-bit-division-in-slab_put_obj.patch
-mm-hugepage-accounting-fix.patch
-zone_reclaim-do-not-unmap-file-backed-pages.patch
-zone_reclaim-partial-scans-instead-of-full-scan.patch
-#shrink_list-use-of-instead-leads-to-unintended-writing.patch
-direct-migration-v9-pageswapcache-checks.patch
-direct-migration-v9-migrate_pages-extension.patch
-direct-migration-v9-migrate_pages-extension-fixes.patch
-direct-migration-v9-migrate_pages-extension-fix2.patch
-direct-migration-v9-migrate_pages-extension-fix3.patch
-direct-migration-v9-remove_from_swap-to-remove-swap-ptes.patch
-direct-migration-v9-remove_from_swap-to-remove-swap-ptes-fixes.patch
-direct-migration-v9-upgrade-mpol_mf_move-and-sys_migrate_pages.patch
-direct-migration-v9-upgrade-mpol_mf_move-and-sys_migrate_pages-fixes.patch
-direct-migration-v9-avoid-writeback--page_migrate-method.patch
-direct-migration-v9-avoid-writeback--page_migrate-method-remove-unused-export-for-migrate_pages-and-isolate_lru_page.patch
-direct-migration-v9-avoid-writeback--page_migrate-method-fixes.patch
-direct-migration-v9-avoid-writeback-page_migrate-method-locking-fix.patch
-slab-distinguish-between-object-and-buffer-size.patch
-slab-minor-cleanup-to-kmem_cache_alloc_node.patch
-slab-have-index_of-bug-at-compile-time.patch
-slab-cache_estimate-cleanup.patch
-slab-extract-slab_destroy_objs.patch
-slab-extract-slab_putget_obj.patch
-slab-reduce-inlining.patch
-slab-extract-virt_to_cacheslab.patch
-slab-rename-ac_data-to-cpu_cache_get.patch
-slab-replace-kmem_cache_t-with-struct-kmem_cache.patch
-dump_stack-in-oom.patch
-slab-fix-kzalloc-and-kstrdup-caller-report-for-config_debug_slab.patch
-mm-slab-add-kernel-doc-for-one-function.patch
-slab-fix-sparse-warning.patch
-selinux-fix-and-cleanup-mprotect-checks.patch
-selinux-change-file_alloc_security-to-use-gfp_kernel.patch
-selinux-remove-security-struct-magic-number-fields.patch
-powerpc-fix-for-kexec-ppc32.patch
-modalias=-for-macio.patch
-powerpc-fix-sigmask-handling-in-sys_sigsuspend.patch
-sh-sh4-202-microdev-updates.patch
-sh-make-peripheral-clock-frequency-setting-mandatory.patch
-sh-move-tra-expevt-intevt-definitions-for-reuse.patch
-sh-cleanup-struct-sh_cpuinfo-for-clock-framework-changes.patch
-sh-unknown-mach-type-updates.patch
-sh-drop-maskpos-from-make_ipr_irq-remove-duplicate-irq-definitions.patch
-sh-convert-voyagergx-to-platform-device-drop-sh-bus.patch
-sh-sh-sci-clock-framework-updates.patch
-sh-add-missing-timers-directory-rule-to-build.patch
-sh-machine_halt-machine_power_off-cleanups.patch
-sh-sh64-fix-bogus-tiocgicount-definitions.patch
-arch-sh64-kernel-timec-add-moduleh.patch
-vmsplit-config-options.patch
-alpha-fix-getxpid-on-alpha-so-it-works-for-threads.patch
-arm26-fix-find_first_zero_bit-related-warnings.patch
-arm26-fix-warnings-about-nr_irqs-being-not-defined.patch
-arm26-remove-irq_exit-from-hardirqh.patch
-arm26-select-system-type-via-choice.patch
-arm26-fixup-get_signal_to_deliver-call.patch
-arm26-fixup-asm-statement-in-kernel-fiqc.patch
-arm26-drop-local-task_running-copy.patch
-arm26-drop-first-arg-of-prepare_arch_switch-finish_arch_switch.patch
-arm26-add-__kernel_old_dev_t-for-nfsd.patch
-arm26-select-blk_dev_fd-only-on-a5k.patch
-swsusp-use-bytes-as-image-size-units.patch
-uml-add-a-build-dependency.patch
-uml-fix-some-typos.patch
-uml-typo-fixup.patch
-uml-comments-about-libc-conflict-guards.patch
-uml-fix-hugest-stack-users.patch
-uml-fix-apples-bananas-typo.patch
-uml-tt-syscall_debug-fix-buglet-introduced-in-cleanup.patch
-uml-skas0-hold-own-ldt-fixups-for-x86-64.patch
-uml-some-harmless-sparse-warning-fixes.patch
-uml-avoid-config_nr_cpus-undeclared-bogus-error-messages.patch
-xtensa-add-asm-futexh.patch
-s390-build-dasd_cmd-into-dasd_mod.patch
-s390-dasd-remove-dynamic-ioctl-registration.patch
-s390-dasd-remove-dynamic-ioctl-registration-fix.patch
-s390-remove-cvs-generated-information.patch
-s390-overflow-in-sched_clock.patch
-s390-monotonic_clock-interface.patch
-s390-hangcheck-timer-support.patch
-s390-ccw_device_probe_console-return-value.patch
-s390-dasd-open-counter.patch
-s390-dasd-wait-for-clear-i-o-interrupt.patch
-s390-new-default-configuration.patch
-s390-add-support-for-new-syscalls-tif_restore_sigmask.patch
-s390-fix-modalias-for-ccw-devices.patch
-s390-add-missing-memory-constraint-to-stcrw.patch
-define-bits_per_byte.patch
-introduce-__iowrite32_copy.patch
-add-faster-__iowrite32_copy-routine-for-x86_64.patch
-sem2mutex-infiniband-2.patch
-sem2mutex-jfs.patch
-reiserfs-remove-kmalloc-wrapper.patch
-reiserfs-use-__gfp_nofail-instead-of-yield-and-retry-loop.patch
-reiserfs-missing-kmalloc-failure-check.patch
-reiserfs-remove-reiserfs_permission_locked.patch
-reiserfs-use-generic_permission.patch
-reiserfs-fix-race-between-invalidatepage-checks-and-data=ordered-writeback.patch
-reiserfs-zero-b_private-when-allocating-buffer-heads.patch
-reiserfs-hang-and-performance-fix-for-data=journal-mode.patch
-reiserfs-write_ordered_buffers-should-not-oops-on-dirty-non-uptodate-bh.patch
-reiserfs-fix-journal-accounting-in-journal_transaction_should_end.patch
-reiserfs-check-for-files-2gb-on-35x-disks.patch
-kernel-kprobesc-fix-a-warning-ifndef-arch_supports_kretprobes.patch
-fbcon-fix-screen-artifacts-when-moving-cursor.patch
-video-hp680-backlight-driver.patch
-i810fb-do-not-probe-the-third-i2c-bus-by-default.patch
-fbdev-fix-usage-of-blank-value-passed-to-fb_blank.patch
-md-fix-device-size-updates-in-md.patch
-md-make-sure-array-geometry-changes-persist-with-version-1-superblocks.patch
-md-dont-remove-bitmap-from-md-array-when-switching-to-read-only.patch
-md-add-sysfs-access-to-raid6-stripe-cache-size.patch
-docbook-allow-even-longer-return-types.patch
-docbook-fix-some-kernel-doc-comments-in-net-sunrpc.patch
-docbook-fix-some-kernel-doc-comments-in-fs-and-block.patch
-doc-kernel-doc-add-more-usage-info.patch
-kernel-doc-clean-up-the-script-whitespace.patch
Merged
+fix-rocketport-driver.patch
+cleanup-documentation-driver-model-overviewtxt.patch
+md-handle-overflow-of-mdu_array_info_t-size-better.patch
+md-assorted-little-md-fixes.patch
+md-make-sure-rdev-size-gets-set-for-version-1-superblocks.patch
+kernel-kprobesc-fix-a-warning-ifndef-arch_supports_kretprobes.patch
+kprobes-fix-deadlock-in-function-return-probes.patch
+fix-build-failure-in-recent-pm_prepare_-changes.patch
+documentation-updated-pci-error-recovery.patch
+fix-generic_fls64.patch
+fix-compilation-errors-in-maps-dc21285c.patch
Fixes for 2.6.16-rc2
+multiple-exports-of-strpbrk.patch
+multiple-exports-of-strpbrk-fix.patch
Fix multiple EXPORT_SYMBOLs
+i386-cpu-hotplug-dont-access-freed-memory.patch
init sectoin fix
+pnpacpi-fix-non-memory-address-space-descriptor-handling.patch
+pnpacpi-remove-some-code-duplication.patch
+pnpacpi-whitespace-cleanup.patch
pnpacpi updates
+simplify-audit_free-locking.patch
audit locking cleanup
-powernow-k7-work-when-kernel-is-compiled-for-smp.patch
Dropped, had problems.
+cpufreq-_ppc-frequency-change-issues-freq-already-lowered-by-bios.patch
cpufreq fix
+gregkh-i2c-i2c-i801-i2c-patch-for-intel-ich8.patch
i2c tree update
+fix-debug-statement-in-inftlcorec.patch
mtd fix
+s2io-c99-warning-fix.patch
+sky2-fix-ethtool-ops.patch
+e100-remove-init_hw-call-to-fix-panic.patch
+8139too-fix-a-tx-timeout-watchdog-thread-against-napi-softirq-race.patch
+ipw2200-warning-fix.patch
+drivers-net-e1000-proper-prototypes.patch
+gianfar-fix-sparse-warnings.patch
+prism54-warning-fix.patch
+sky2-fix-hang-on-yukon-ec-0xb6-rev-1.patch
net driver fixes
+net-convert-rtnl-to-mutex.patch
mutex conversion
+appletalk-warning-fix.patch
+smctr-warning-fix.patch
net fixlets
+gregkh-pci-altix-msi-support-git-ia64-fix.patch
Fix a patch in the PCI tree
+gregkh-usb-usb-remove-usbcore-specific-wakeup-flags.patch
USB tree update
+uhci-hcd-fix-mistaken-usage-of-list_prepare_entry.patch
+gregkh-usb-usb-remove-usbcore-specific-wakeup-flags-fix.patch
USB fixes
+x86_64-pmtimer-variable-fallback.patch
+x86_64-apic-timer-only-with-cx.patch
+x86_64-even-more-cpuinit.patch
+x86_64-iommu-fallback.patch
+x86_64-switchto-no-kprobes.patch
+x86_64-apic-pmtimer-calibrate.patch
+x86_64-cpu_pda-array-to-macro-followup-correction.patch
+x86_64-small-fix-for-cfi-annotations.patch
+x86_64-disallow-multi-byte-hardware-execution-breakpoints.patch
+x86_64-eliminate-set_debug.patch
+x86_64-minor-odering-correction-to-dump_pagetable.patch
+x86_64-save-fpu-context-slightly-later.patch
+x86_64-cleanup-allocating-logical-cpu-numbers-in-x86_64.patch
+x86_64-dont-record-local-apic-ids-when-they-are-disabled-in-madt.patch
+x86_64-pmtimer-dont-touch-pit.patch
+x86_64-boot-report-apicid.patch
+x86_64-bad-apic-ack.patch#X86_64-END
x86_64 updates
+oom-kill-children-accounting.patch
+slab-object-to-index-mapping-cleanup.patch
mm updates
+update-mm-acx-driver-to-version-0331.patch
ACX wireless driver update
+x86-smp-alternatives-fix.patch
+x86-smp-alternatives-fix-2.patch
Fix x86-smp-alternatives.patch
+i386-add-a-temporary-to-make-put_user-more-type-safe-fix.patch
Fix i386-add-a-temporary-to-make-put_user-more-type-safe.patch
+i386-instead-of-poisoning-init-zone-change-protection.patch
x86 debugging
+x86_64-print-the-offset-in-hex-as-opposed-to-decimal-in-stack-dump.patch
Make x86_64 oopses saner-lookng
+s390-dasd-extended-error-reporting-module.patch
+s390-timer-interface-visibility.patch
+s390-compile-fix-missing-defines-in-asm-s390-ioh.patch
+s390-fix-compat-syscall-wrapper.patch
+s390-fix-to_channelpath-macro.patch
s390 update
+kernel-modulec-semaphore-to-mutex-conversion-for-module_mutex.patch
Mutex conversion
-add-trylock_kernel.patch
-add-trylock_kernel-fix.patch
-turn-on-might_sleep-in-early-bootup-code-too.patch
Dropped - a bit messy, scary warnings, not very pointful.
+__generic_per_cpu-changes.patch
per-cpu data changes
-exec-cleanup-exec-from-a-non-thread-group-leader.patch
Dropped
+fat-replace-an-own-implementation-with-ll_rw_blockswrite.patch
+trivial-optimization-of-ll_rw_block.patch
+fat-fix-truncate-write-ordering.patch
+edac_mc-remove-include-of-versionh.patch
+tvec_bases-too-large-for-per-cpu-data.patch
+tvec_bases-too-large-for-per-cpu-data-fix.patch
+remove-drivers-mca-mca-procc.patch
+fix-keyctl-usage-of-strnlen_user.patch
+ip2main-warning-fixes.patch
+i4l-warning-fixes.patch
+debugfs-hard-link-count-wrong.patch
+kconfig-detect-if-lintl-is-needed-when-linking-confmconf.patch
+kconfig-detect-if-lintl-is-needed-when-linking-confmconf-fix.patch
+unify-pxm_to_node-id-ver2-generic-code.patch
+unify-pxm_to_node-id-ver2-for-ia64.patch
+unify-pxm_to_node-id-ver2-for-x86_64.patch
+unify-pxm_to_node-id-ver2-for-i386.patch
+extract-ikconfig-use-mktemp1.patch
+extract-ikconfig-be-sure-binoffset-exists-before-extracting.patch
+extract-ikconfig-dont-use-long-options.patch
+vfs-ensure-lookup_continue-flag-is-preserved-by.patch
Misc
+exec-allow-init-to-exec-from-any-thread.patch
+simplify-exec-from-inits-subthread.patch
-pid-dont-hash-pid-0.patch
+pidhash-dont-count-idle-threads.patch
+pidhash-dont-use-zero-pids.patch
+dont-touch-current-tasks-in-de_thread.patch
+choose_new_parent-remove-unused-arg-sanitize-exit_state-check.patch
Various core kernel cleanups from Oleg and Eric.
+mempool-add-page-allocator.patch
+mempool-add-page-allocator-fix.patch
+mempool-add-page-allocator-fix-2.patch
+mempool-use-common-mempool-page-allocator.patch
+mempool-add-kmalloc-allocator.patch
+mempool-use-common-mempool-kmalloc-allocator.patch
+mempool-add-kzalloc-allocator.patch
+mempool-add-kmalloc-allocator-fix.patch
+mempool-use-common-mempool-kzalloc-allocator.patch
+mempool-add-mempool_create_slab_pool.patch
+mempool-add-mempool_create_slab_pool-fix.patch
+mempool-add-mempool_create_slab_pool-update.patch
+mempool-use-mempool_create_slab_pool.patch
mempool code librarification
+time-reduced-ntp-rework-part-1.patch
+time-reduced-ntp-rework-part-2.patch
+time-reduced-ntp-rework-part-2-fix.patch
+time-clocksource-infrastructure.patch
+time-clocksource-infrastructure-fix-clocksource_lock-deadlock.patch
+time-generic-timekeeping-infrastructure.patch
+time-i386-conversion-part-1-move-timer_pitc-to-i8253c.patch
+time-i386-conversion-part-2-rework-tsc-support.patch
+time-i386-conversion-part-2-rework-tsc-support-c2-fix.patch
+time-i386-conversion-part-3-enable-generic-timekeeping.patch
+time-i386-conversion-part-4-remove-old-timer_opts-code.patch
+time-i386-conversion-part-5-acpi-pm-variable-renaming-and-config-change.patch
+time-i386-clocksource-drivers.patch
+time-fix-cpu-frequency-detection.patch
+time-delay-clocksource-selection-until-later-in-boot.patch
+x86-blacklist-tsc-from-systems-where-it-is-known-to-be-bad.patch
Bring back John's time-reqork patches. New, improved, fixed.
+kprobes-clean-up-resume_execute.patch
+x86-kprobes-booster.patch
+kretprobe-kretprobe-booster.patch
kprobes cleanup and speedups
+sched-new-sched-domain-for-representing-multi-core.patch
+sched-new-sched-domain-for-representing-multi-core-fix.patch
+sched-new-sched-domain-for-representing-multi-core-default-y.patch
Multicore support in the CPU scheduler.
+sis5513-support-sis-965l.patch
Bring back this IDE fix
+vgacon-add-support-for-soft-scrollback-fix.patch
Fix vgacon-add-support-for-soft-scrollback.patch
+pidhash-temporal-debug-checks.patch
pid debugging
All 869 patches:
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.6.16-rc1-mm5/patch-list
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2.6.16-rc1-mm5
2006-02-03 8:07 2.6.16-rc1-mm5 Andrew Morton
@ 2006-02-03 10:17 ` Benoit Boissinot
2006-02-03 20:13 ` 2.6.16-rc1-mm5 Benoit Boissinot
2006-02-03 11:51 ` [-mm patch] Makefile: remove a tab from an empty line Adrian Bunk
` (8 subsequent siblings)
9 siblings, 1 reply; 25+ messages in thread
From: Benoit Boissinot @ 2006-02-03 10:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On 2/3/06, Andrew Morton <akpm@osdl.org> wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.6.16-rc1-mm5/
>
>
> - The ntp/time rework patches from John Stultz have been resurrected and fixed.
>
> - There's now a `hot-fixes' directory at the above URL. Please look in
> there for any updates which should be applied.
It runs fine here, no problems. Even iptables works this time.
thanks
Benoit
^ permalink raw reply [flat|nested] 25+ messages in thread
* [-mm patch] Makefile: remove a tab from an empty line
2006-02-03 8:07 2.6.16-rc1-mm5 Andrew Morton
2006-02-03 10:17 ` 2.6.16-rc1-mm5 Benoit Boissinot
@ 2006-02-03 11:51 ` Adrian Bunk
2006-02-03 20:57 ` [-mm patch] kernel/time/timeofday.c: make struct ts_interval static Adrian Bunk
` (7 subsequent siblings)
9 siblings, 0 replies; 25+ messages in thread
From: Adrian Bunk @ 2006-02-03 11:51 UTC (permalink / raw)
To: Andrew Morton, sam; +Cc: linux-kernel
On Fri, Feb 03, 2006 at 12:07:04AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.15-mm4:
>...
> git-kbuild.patch
>...
> Git trees
>...
Emacs warns if an otherwise empty line starts with a tab.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc1-mm5-full/Makefile.old 2006-02-03 12:46:09.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/Makefile 2006-02-03 12:46:31.000000000 +0100
@@ -1122,7 +1122,7 @@
.PHONY: modules_install
modules_install: _emodinst_ _emodinst_post
-
+
install-dir := $(if $(INSTALL_MOD_DIR),$(INSTALL_MOD_DIR),extra)
.PHONY: _emodinst_
_emodinst_:
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2.6.16-rc1-mm5
2006-02-03 10:17 ` 2.6.16-rc1-mm5 Benoit Boissinot
@ 2006-02-03 20:13 ` Benoit Boissinot
2006-02-03 20:36 ` 2.6.16-rc1-mm5 Andrew Morton
0 siblings, 1 reply; 25+ messages in thread
From: Benoit Boissinot @ 2006-02-03 20:13 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On 2/3/06, Benoit Boissinot <bboissin@gmail.com> wrote:
> On 2/3/06, Andrew Morton <akpm@osdl.org> wrote:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.6.16-rc1-mm5/
> >
> >
> > - The ntp/time rework patches from John Stultz have been resurrected and fixed.
> >
> > - There's now a `hot-fixes' directory at the above URL. Please look in
> > there for any updates which should be applied.
>
> It runs fine here, no problems. Even iptables works this time.
Actually it spoke too fast, I have the following oops with
CONFIG_DEBUG_INITDATA=y (it does not oops without this config
option).
I can send full dmesg and .config if needed (the bug is reproducable).
with gcc4.1 (I supposed buffered_rmqueue is inlined):
BUG: unable to handle kernel paging request at virtual address c0401000
printing eip:
c013ea41
*pde = 1ff0a163
*pte = 00401000
Oops: 0002 [#1]
last sysfs file: /devices/pci0000:00/0000:00:1e.0/0000:02:03.0/rf_kill
Modules linked in: aes ieee80211_crypt_ccmp radeon drm ipt_multiport xt_state xt_limit ipt_REJECT xt_tcpudp iptable_filter iptable_nat ip_nat ip_tables x_tables ip_conntrack_irc ip_conntrack_ftp ip_conntrack nfnetlink snd_seq snd_seq_device snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc speedstep_centrino cpufreq_stats freq_table cpufreq_conservative cpufreq_ondemand cpufreq_performance cpufreq_powersave fan button thermal processor battery ac uhci_hcd ehci_hcd usbcore tg3 ipw2200 ieee80211 ieee80211_crypt psmouse ide_cd cdrom
CPU: 0
EIP: 0060:[<c013ea41>] Not tainted VLI
EFLAGS: 00010287 (2.6.16-rc1-mm5-casaverde #15)
EIP is at get_page_from_freelist+0x2d1/0x330
eax: 00000000 ebx: 00000000 ecx: 00000400 edx: 00000400
esi: c1008020 edi: c0401000 ebp: da64eed8 esp: da64ee8c
ds: 007b es: 007b ss: 0068
Process hg (pid: 18179, threadinfo=da64e000 task=da437560)
Stack: <0>00000002 00000044 c1008020 00000001 00000001 c03b8b60 00000000 c03b8b40
00000002 00000000 000280d2 c03b900c 00000000 00000202 00000000 00000001
c03b9008 da437560 000280d2 da64ef18 c013f1b5 00000044 00000000 00000000
Call Trace:
<c0103f05> show_stack_log_lvl+0xc5/0xf0 <c01040ba> show_registers+0x18a/0x210
<c010421f> die+0xdf/0x1f0 <c0114266> do_page_fault+0x276/0x5ec
<c010391f> error_code+0x4f/0x54 <c013f1b5> __alloc_pages+0x55/0x2c0
<c01461d4> __handle_mm_fault+0x3f4/0x730 <c01143b4> do_page_fault+0x3c4/0x5ec
<c010391f> error_code+0x4f/0x54
Code: 89 75 bc 31 db ba 00 04 00 00 c7 45 e4 00 00 00 00 a1 30 66 45 c0 89 d1 8b 7d bc 29 c7 89 d8 c1 ff 05 c1 e7 0c 81 ef 00 00 00 40 <f3> ab ff 45 e4 83 45 bc 20 8b 4d e4 39 4d c4 75 d5 e9 15 ff ff
with gcc-3.4:
BUG: unable to handle kernel paging request at virtual address c0450000
printing eip:
c013fdf9
*pde = 1ff37163
*pte = 00450000
Oops: 0002 [#1]
last sysfs file: /devices/pci0000:00/0000:00:1e.0/0000:02:03.0/rf_kill
Modules linked in: radeon drm aes ieee80211_crypt_ccmp ipt_multiport xt_state xt_limit ipt_REJECT xt_tcpudp iptable_filter iptable_nat ip_nat ip_tables x_tables ip_conntrack_irc ip_conntrack_ftp ip_conntrack nfnetlink snd_seq snd_seq_device snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc speedstep_centrino cpufreq_stats freq_table cpufreq_conservative cpufreq_ondemand cpufreq_performance cpufreq_powersave fan button thermal processor battery ac uhci_hcd ehci_hcd usbcore tg3 ipw2200 ieee80211 ieee80211_crypt psmouse ide_cd cdrom
CPU: 0
EIP: 0060:[<c013fdf9>] Not tainted VLI
EFLAGS: 00210287 (2.6.16-rc1-mm5-casaverde #17)
EIP is at buffered_rmqueue+0x169/0x1f0
eax: 00000000 ebx: 00000400 ecx: 00000400 edx: c1008a00
esi: 00000000 edi: c0450000 ebp: dfa67c74 esp: dfa67c50
ds: 007b es: 007b ss: 0068
Process hg (pid: 7823, threadinfo=dfa67000 task=df95e560)
Stack: <0>c03d206c 00000001 00000000 c1008a00 00200246 00000000 c03d250c 00000044
00000000 dfa67ca0 c013ffe3 000280d2 00000044 00000002 c03d2508 00000000
000280d2 c03d2508 000280d2 df95e560 dfa67cdc c014005e 00000044 c01fbcf3
Call Trace:
<c0103d01> show_stack_log_lvl+0xa1/0xe0 <c0103ee4> show_registers+0x174/0x1f0
<c01040d2> die+0xd2/0x160 <c011458f> do_page_fault+0x39f/0x599
<c0103953> error_code+0x4f/0x54 <c013ffe3> get_page_from_freelist+0xa3/0xd0
<c014005e> __alloc_pages+0x4e/0x2b0 <c0148790> do_anonymous_page+0x40/0x130
<c0148b9f> __handle_mm_fault+0xaf/0x210 <c01143ae> do_page_fault+0x1be/0x599
<c0103953> error_code+0x4f/0x54 <c013bf4c> do_generic_mapping_read+0x3ec/0x610
<c013c3e4> __generic_file_aio_read+0x184/0x200 <c013c557> generic_file_read+0x97/0xc0
<c0158078> vfs_read+0x88/0x160 <c01583fd> sys_read+0x3d/0x70
<c0102e3f> sysenter_past_esp+0x54/0x75
Code: 00 7e 32 89 7d e0 8b 55 e8 31 f6 bb 00 04 00 00 89 f6 a1 30 96 47 c0 89 d7 89 d9 29 c7 c1 ff 05 89 f0 c1 e7 0c 81 ef 00 00 00 40 <f3> ab 83 c2 20 ff 4d e0 75 dd 8b 5d f0 85 db 74 09 f7 45 08 00
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2.6.16-rc1-mm5
2006-02-03 20:13 ` 2.6.16-rc1-mm5 Benoit Boissinot
@ 2006-02-03 20:36 ` Andrew Morton
0 siblings, 0 replies; 25+ messages in thread
From: Andrew Morton @ 2006-02-03 20:36 UTC (permalink / raw)
To: Benoit Boissinot; +Cc: linux-kernel
Benoit Boissinot <bboissin@gmail.com> wrote:
>
> On 2/3/06, Benoit Boissinot <bboissin@gmail.com> wrote:
> > On 2/3/06, Andrew Morton <akpm@osdl.org> wrote:
> > >
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc1/2.6.16-rc1-mm5/
> > >
> > >
> > > - The ntp/time rework patches from John Stultz have been resurrected and fixed.
> > >
> > > - There's now a `hot-fixes' directory at the above URL. Please look in
> > > there for any updates which should be applied.
> >
> > It runs fine here, no problems. Even iptables works this time.
>
> Actually it spoke too fast, I have the following oops with
> CONFIG_DEBUG_INITDATA=y (it does not oops without this config
> option).
>
> I can send full dmesg and .config if needed (the bug is reproducable).
>
> with gcc4.1 (I supposed buffered_rmqueue is inlined):
>
> BUG: unable to handle kernel paging request at virtual address c0401000
> printing eip:
> c013ea41
> *pde = 1ff0a163
> *pte = 00401000
> Oops: 0002 [#1]
> last sysfs file: /devices/pci0000:00/0000:00:1e.0/0000:02:03.0/rf_kill
> Modules linked in: aes ieee80211_crypt_ccmp radeon drm ipt_multiport xt_state xt_limit ipt_REJECT xt_tcpudp iptable_filter iptable_nat ip_nat ip_tables x_tables ip_conntrack_irc ip_conntrack_ftp ip_conntrack nfnetlink snd_seq snd_seq_device snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc speedstep_centrino cpufreq_stats freq_table cpufreq_conservative cpufreq_ondemand cpufreq_performance cpufreq_powersave fan button thermal processor battery ac uhci_hcd ehci_hcd usbcore tg3 ipw2200 ieee80211 ieee80211_crypt psmouse ide_cd cdrom
> CPU: 0
> EIP: 0060:[<c013ea41>] Not tainted VLI
> EFLAGS: 00010287 (2.6.16-rc1-mm5-casaverde #15)
> EIP is at get_page_from_freelist+0x2d1/0x330
> eax: 00000000 ebx: 00000000 ecx: 00000400 edx: 00000400
> esi: c1008020 edi: c0401000 ebp: da64eed8 esp: da64ee8c
> ds: 007b es: 007b ss: 0068
> Process hg (pid: 18179, threadinfo=da64e000 task=da437560)
> Stack: <0>00000002 00000044 c1008020 00000001 00000001 c03b8b60 00000000 c03b8b40
> 00000002 00000000 000280d2 c03b900c 00000000 00000202 00000000 00000001
> c03b9008 da437560 000280d2 da64ef18 c013f1b5 00000044 00000000 00000000
> Call Trace:
> <c0103f05> show_stack_log_lvl+0xc5/0xf0 <c01040ba> show_registers+0x18a/0x210
> <c010421f> die+0xdf/0x1f0 <c0114266> do_page_fault+0x276/0x5ec
> <c010391f> error_code+0x4f/0x54 <c013f1b5> __alloc_pages+0x55/0x2c0
> <c01461d4> __handle_mm_fault+0x3f4/0x730 <c01143b4> do_page_fault+0x3c4/0x5ec
> <c010391f> error_code+0x4f/0x54
Ahem, I don't think I actually tested that.
This would seem to be needed, but I don't think it'll fix that one.
From: Andrew Morton <akpm@osdl.org>
Don't touch page_state[not-possible-CPU].
And a couple of little optimisations.
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
mm/page_alloc.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff -puN mm/page_alloc.c~reduce-size-of-percpudata-and-make-sure-per_cpuobject-update2 mm/page_alloc.c
--- devel/mm/page_alloc.c~reduce-size-of-percpudata-and-make-sure-per_cpuobject-update2 2006-02-03 12:26:33.000000000 -0800
+++ devel-akpm/mm/page_alloc.c 2006-02-03 12:34:34.000000000 -0800
@@ -1213,18 +1213,21 @@ static void __get_page_state(struct page
{
int cpu = 0;
- memset(ret, 0, sizeof(*ret));
+ memset(ret, 0, nr * sizeof(unsigned long));
cpus_and(*cpumask, *cpumask, cpu_online_map);
cpu = first_cpu(*cpumask);
while (cpu < NR_CPUS) {
unsigned long *in, *out, off;
+ if (!cpu_isset(cpu, *cpumask))
+ continue;
+
in = (unsigned long *)&per_cpu(page_states, cpu);
cpu = next_cpu(cpu, *cpumask);
- if (cpu < NR_CPUS)
+ if (likely(cpu < NR_CPUS))
prefetch(&per_cpu(page_states, cpu));
out = (unsigned long *)ret;
@@ -1886,8 +1889,7 @@ static void setup_pagelist_highmark(stru
* not check if the processor is online before following the pageset pointer.
* Other parts of the kernel may not check if the zone is available.
*/
-static struct per_cpu_pageset
- boot_pageset[NR_CPUS];
+static struct per_cpu_pageset boot_pageset[NR_CPUS];
/*
* Dynamically allocate memory for the
_
^ permalink raw reply [flat|nested] 25+ messages in thread
* [-mm patch] kernel/time/timeofday.c: make struct ts_interval static
2006-02-03 8:07 2.6.16-rc1-mm5 Andrew Morton
2006-02-03 10:17 ` 2.6.16-rc1-mm5 Benoit Boissinot
2006-02-03 11:51 ` [-mm patch] Makefile: remove a tab from an empty line Adrian Bunk
@ 2006-02-03 20:57 ` Adrian Bunk
2006-02-03 21:50 ` john stultz
2006-02-03 20:59 ` [-mm patch] kernel/timer.c: make some variables static Adrian Bunk
` (6 subsequent siblings)
9 siblings, 1 reply; 25+ messages in thread
From: Adrian Bunk @ 2006-02-03 20:57 UTC (permalink / raw)
To: Andrew Morton, John Stultz; +Cc: linux-kernel
On Fri, Feb 03, 2006 at 12:07:04AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.15-mm4:
>...
> +time-generic-timekeeping-infrastructure.patch
>...
> Bring back John's time-reqork patches. New, improved, fixed.
>...
This patch makes a needlessly global struct static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc1-mm5-full/kernel/time/timeofday.c.old 2006-02-03 20:04:56.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/kernel/time/timeofday.c 2006-02-03 20:05:09.000000000 +0100
@@ -80,7 +80,7 @@
* This constant is the requested fixed interval period
* in nanoseconds.
*/
-struct clocksource_interval ts_interval;
+static struct clocksource_interval ts_interval;
#define INTERVAL_LEN ((PERIODIC_INTERVAL_MS-1)*1000000)
/* [clocksource data]
^ permalink raw reply [flat|nested] 25+ messages in thread
* [-mm patch] kernel/timer.c: make some variables static
2006-02-03 8:07 2.6.16-rc1-mm5 Andrew Morton
` (2 preceding siblings ...)
2006-02-03 20:57 ` [-mm patch] kernel/time/timeofday.c: make struct ts_interval static Adrian Bunk
@ 2006-02-03 20:59 ` Adrian Bunk
2006-02-03 21:02 ` [-mm patch] net/ipv4/fib_rules.c: make struct fib_rules static again Adrian Bunk
` (5 subsequent siblings)
9 siblings, 0 replies; 25+ messages in thread
From: Adrian Bunk @ 2006-02-03 20:59 UTC (permalink / raw)
To: Andrew Morton, john stultz; +Cc: linux-kernel
On Fri, Feb 03, 2006 at 12:07:04AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.15-mm4:
>...
> +time-reduced-ntp-rework-part-2.patch
>...
> Bring back John's time-reqork patches. New, improved, fixed.
>...
This patch makes some needlessly global variables static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
kernel/timer.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
--- linux-2.6.16-rc1-mm5-full/kernel/timer.c.old 2006-02-03 20:05:54.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/kernel/timer.c 2006-02-03 20:07:35.000000000 +0100
@@ -590,12 +590,12 @@
long time_reftime; /* time at last adjustment (s) */
long time_adjust;
long time_next_adjust;
-long time_adjust_step; /* per tick time_adjust step */
+static long time_adjust_step; /* per tick time_adjust step */
-long total_sppm; /* shifted ppm sum of all adjustments */
-long offset_adj_ppm;
-long tick_adj_ppm;
-long singleshot_adj_ppm;
+static long total_sppm; /* shifted ppm sum of all adjustments */
+static long offset_adj_ppm;
+static long tick_adj_ppm;
+static long singleshot_adj_ppm;
#define MAX_SINGLESHOT_ADJ 500 /* (ppm) */
#define SEC_PER_DAY 86400
^ permalink raw reply [flat|nested] 25+ messages in thread
* [-mm patch] net/ipv4/fib_rules.c: make struct fib_rules static again
2006-02-03 8:07 2.6.16-rc1-mm5 Andrew Morton
` (3 preceding siblings ...)
2006-02-03 20:59 ` [-mm patch] kernel/timer.c: make some variables static Adrian Bunk
@ 2006-02-03 21:02 ` Adrian Bunk
2006-02-04 23:51 ` David S. Miller
2006-02-03 21:09 ` [-mm patch] make some "struct clocksource" static Adrian Bunk
` (4 subsequent siblings)
9 siblings, 1 reply; 25+ messages in thread
From: Adrian Bunk @ 2006-02-03 21:02 UTC (permalink / raw)
To: Andrew Morton, Robert Olsson, davem; +Cc: linux-kernel, netdev
On Fri, Feb 03, 2006 at 12:07:04AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.15-mm4:
>...
> git-net.patch
>...
> Git trees
>...
struct fib_rules became global for no good reason.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc1-mm5-full/net/ipv4/fib_rules.c.old 2006-02-03 16:12:48.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/net/ipv4/fib_rules.c 2006-02-03 16:13:00.000000000 +0100
@@ -100,7 +100,7 @@
.r_action = RTN_UNICAST,
};
-struct hlist_head fib_rules;
+static struct hlist_head fib_rules;
/* writer func called from netlink -- rtnl_sem hold*/
^ permalink raw reply [flat|nested] 25+ messages in thread
* [-mm patch] make some "struct clocksource" static
2006-02-03 8:07 2.6.16-rc1-mm5 Andrew Morton
` (4 preceding siblings ...)
2006-02-03 21:02 ` [-mm patch] net/ipv4/fib_rules.c: make struct fib_rules static again Adrian Bunk
@ 2006-02-03 21:09 ` Adrian Bunk
2006-02-03 21:12 ` [-mm patch] arch/i386/kernel/cpu/: make tons of functions static Adrian Bunk
` (3 subsequent siblings)
9 siblings, 0 replies; 25+ messages in thread
From: Adrian Bunk @ 2006-02-03 21:09 UTC (permalink / raw)
To: Andrew Morton, john stultz; +Cc: linux-kernel
On Fri, Feb 03, 2006 at 12:07:04AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.15-mm4:
>...
> +time-i386-clocksource-drivers.patch
>...
> Bring back John's time-reqork patches. New, improved, fixed.
>...
This patch makes some needlessly global structs static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
arch/i386/kernel/hpet.c | 2 +-
drivers/clocksource/acpi_pm.c | 2 +-
drivers/clocksource/cyclone.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.16-rc1-mm5-full/arch/i386/kernel/hpet.c.old 2006-02-03 16:33:22.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/arch/i386/kernel/hpet.c 2006-02-03 16:33:32.000000000 +0100
@@ -19,7 +19,7 @@
return (cycle_t)readl(hpet_ptr);
}
-struct clocksource clocksource_hpet = {
+static struct clocksource clocksource_hpet = {
.name = "hpet",
.rating = 250,
.read = read_hpet,
--- linux-2.6.16-rc1-mm5-full/drivers/clocksource/acpi_pm.c.old 2006-02-03 16:36:43.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/drivers/clocksource/acpi_pm.c 2006-02-03 16:36:51.000000000 +0100
@@ -70,7 +70,7 @@
return (cycle_t)read_pmtmr();
}
-struct clocksource clocksource_acpi_pm = {
+static struct clocksource clocksource_acpi_pm = {
.name = "acpi_pm",
.rating = 200,
.read = acpi_pm_read,
--- linux-2.6.16-rc1-mm5-full/drivers/clocksource/cyclone.c.old 2006-02-03 16:37:01.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/drivers/clocksource/cyclone.c 2006-02-03 16:37:11.000000000 +0100
@@ -24,7 +24,7 @@
return (cycle_t)readl(cyclone_ptr);
}
-struct clocksource clocksource_cyclone = {
+static struct clocksource clocksource_cyclone = {
.name = "cyclone",
.rating = 250,
.read = read_cyclone,
^ permalink raw reply [flat|nested] 25+ messages in thread
* [-mm patch] arch/i386/kernel/cpu/: make tons of functions static
2006-02-03 8:07 2.6.16-rc1-mm5 Andrew Morton
` (5 preceding siblings ...)
2006-02-03 21:09 ` [-mm patch] make some "struct clocksource" static Adrian Bunk
@ 2006-02-03 21:12 ` Adrian Bunk
2006-02-03 21:25 ` 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken Adrian Bunk
` (2 subsequent siblings)
9 siblings, 0 replies; 25+ messages in thread
From: Adrian Bunk @ 2006-02-03 21:12 UTC (permalink / raw)
To: Andrew Morton, Chuck Ebbert; +Cc: linux-kernel
On Fri, Feb 03, 2006 at 12:07:04AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.15-mm4:
>...
> +i386-cpu-hotplug-dont-access-freed-memory.patch
>
> init sectoin fix
>...
Functions only used in the files they are defined in should be static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
arch/i386/kernel/cpu/amd.c | 2 +-
arch/i386/kernel/cpu/centaur.c | 2 +-
arch/i386/kernel/cpu/cyrix.c | 4 ++--
arch/i386/kernel/cpu/nexgen.c | 2 +-
arch/i386/kernel/cpu/rise.c | 2 +-
arch/i386/kernel/cpu/transmeta.c | 2 +-
arch/i386/kernel/cpu/umc.c | 2 +-
7 files changed, 8 insertions(+), 8 deletions(-)
--- linux-2.6.16-rc1-mm5-full/arch/i386/kernel/cpu/amd.c.old 2006-02-03 16:14:11.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/arch/i386/kernel/cpu/amd.c 2006-02-03 16:14:24.000000000 +0100
@@ -283,7 +283,7 @@
//early_arch_initcall(amd_init_cpu);
-int __init amd_exit_cpu(void)
+static int __init amd_exit_cpu(void)
{
cpu_devs[X86_VENDOR_AMD] = NULL;
return 0;
--- linux-2.6.16-rc1-mm5-full/arch/i386/kernel/cpu/centaur.c.old 2006-02-03 16:14:32.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/arch/i386/kernel/cpu/centaur.c 2006-02-03 16:14:42.000000000 +0100
@@ -471,7 +471,7 @@
//early_arch_initcall(centaur_init_cpu);
-int __init centaur_exit_cpu(void)
+static int __init centaur_exit_cpu(void)
{
cpu_devs[X86_VENDOR_CENTAUR] = NULL;
return 0;
--- linux-2.6.16-rc1-mm5-full/arch/i386/kernel/cpu/cyrix.c.old 2006-02-03 16:15:00.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/arch/i386/kernel/cpu/cyrix.c 2006-02-03 16:15:21.000000000 +0100
@@ -444,7 +444,7 @@
//early_arch_initcall(cyrix_init_cpu);
-int __init cyrix_exit_cpu(void)
+static int __init cyrix_exit_cpu(void)
{
cpu_devs[X86_VENDOR_CYRIX] = NULL;
return 0;
@@ -467,7 +467,7 @@
//early_arch_initcall(nsc_init_cpu);
-int __init nsc_exit_cpu(void)
+static int __init nsc_exit_cpu(void)
{
cpu_devs[X86_VENDOR_NSC] = NULL;
return 0;
--- linux-2.6.16-rc1-mm5-full/arch/i386/kernel/cpu/nexgen.c.old 2006-02-03 16:15:38.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/arch/i386/kernel/cpu/nexgen.c 2006-02-03 16:15:44.000000000 +0100
@@ -62,7 +62,7 @@
//early_arch_initcall(nexgen_init_cpu);
-int __init nexgen_exit_cpu(void)
+static int __init nexgen_exit_cpu(void)
{
cpu_devs[X86_VENDOR_NEXGEN] = NULL;
return 0;
--- linux-2.6.16-rc1-mm5-full/arch/i386/kernel/cpu/rise.c.old 2006-02-03 16:15:57.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/arch/i386/kernel/cpu/rise.c 2006-02-03 16:16:27.000000000 +0100
@@ -52,7 +52,7 @@
//early_arch_initcall(rise_init_cpu);
-int __init rise_exit_cpu(void)
+static int __init rise_exit_cpu(void)
{
cpu_devs[X86_VENDOR_RISE] = NULL;
return 0;
--- linux-2.6.16-rc1-mm5-full/arch/i386/kernel/cpu/transmeta.c.old 2006-02-03 16:16:37.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/arch/i386/kernel/cpu/transmeta.c 2006-02-03 16:16:50.000000000 +0100
@@ -112,7 +112,7 @@
//early_arch_initcall(transmeta_init_cpu);
-int __init transmeta_exit_cpu(void)
+static int __init transmeta_exit_cpu(void)
{
cpu_devs[X86_VENDOR_TRANSMETA] = NULL;
return 0;
--- linux-2.6.16-rc1-mm5-full/arch/i386/kernel/cpu/umc.c.old 2006-02-03 16:17:02.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/arch/i386/kernel/cpu/umc.c 2006-02-03 16:17:12.000000000 +0100
@@ -32,7 +32,7 @@
//early_arch_initcall(umc_init_cpu);
-int __init umc_exit_cpu(void)
+static int __init umc_exit_cpu(void)
{
cpu_devs[X86_VENDOR_UMC] = NULL;
return 0;
^ permalink raw reply [flat|nested] 25+ messages in thread
* 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken
2006-02-03 8:07 2.6.16-rc1-mm5 Andrew Morton
` (6 preceding siblings ...)
2006-02-03 21:12 ` [-mm patch] arch/i386/kernel/cpu/: make tons of functions static Adrian Bunk
@ 2006-02-03 21:25 ` Adrian Bunk
2006-02-04 2:43 ` Jody McIntyre
` (2 more replies)
2006-02-04 7:59 ` 2.6.16-rc1-mm5 Matthias Urlichs
2006-02-04 9:29 ` 2.6.16-rc1-mm5 Sam Ravnborg
9 siblings, 3 replies; 25+ messages in thread
From: Adrian Bunk @ 2006-02-03 21:25 UTC (permalink / raw)
To: Andrew Morton, bcollins, scjody; +Cc: linux-kernel, linux1394-devel, sam
On Fri, Feb 03, 2006 at 12:07:04AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.15-mm4:
>...
> git-ieee1394.patch
>...
> Git trees
>...
<-- snip -->
...
OUI2C drivers/ieee1394/oui.c
/bin/sh: drivers/ieee1394/oui2c.sh: No such file or directory
make[3]: *** [drivers/ieee1394/oui.c] Error 127
<-- snip -->
The change that broke it is:
quiet_cmd_oui2c = OUI2C $@
- cmd_oui2c = $(CONFIG_SHELL) $(srctree)/$(src)/oui2c.sh < $< > $@
+ cmd_oui2c = $(CONFIG_SHELL) $(src)/oui2c.sh < $< > $@
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [-mm patch] kernel/time/timeofday.c: make struct ts_interval static
2006-02-03 20:57 ` [-mm patch] kernel/time/timeofday.c: make struct ts_interval static Adrian Bunk
@ 2006-02-03 21:50 ` john stultz
0 siblings, 0 replies; 25+ messages in thread
From: john stultz @ 2006-02-03 21:50 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel
On Fri, 2006-02-03 at 21:57 +0100, Adrian Bunk wrote:
> On Fri, Feb 03, 2006 at 12:07:04AM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.15-mm4:
> >...
> > +time-generic-timekeeping-infrastructure.patch
> >...
> > Bring back John's time-reqork patches. New, improved, fixed.
> >...
>
>
> This patch makes a needlessly global struct static.
Ah! Great catches on all three of these patches!
Acked-by: John Stultz <johnstul@us.ibm.com>
Thanks so much!
-john
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken
2006-02-03 21:25 ` 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken Adrian Bunk
@ 2006-02-04 2:43 ` Jody McIntyre
2006-02-04 9:20 ` Sam Ravnborg
2006-02-04 9:08 ` Stefan Richter
2006-02-06 4:31 ` Jody McIntyre
2 siblings, 1 reply; 25+ messages in thread
From: Jody McIntyre @ 2006-02-04 2:43 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, bcollins, linux-kernel, linux1394-devel, sam
On Fri, Feb 03, 2006 at 10:25:07PM +0100, Adrian Bunk wrote:
> ...
> OUI2C drivers/ieee1394/oui.c
> /bin/sh: drivers/ieee1394/oui2c.sh: No such file or directory
> make[3]: *** [drivers/ieee1394/oui.c] Error 127
I can't reproduce this. What steps are you using to build the kernel?
Cheers,
Jody
>
> <-- snip -->
>
>
> The change that broke it is:
>
>
> quiet_cmd_oui2c = OUI2C $@
> - cmd_oui2c = $(CONFIG_SHELL) $(srctree)/$(src)/oui2c.sh < $< > $@
> + cmd_oui2c = $(CONFIG_SHELL) $(src)/oui2c.sh < $< > $@
>
>
> cu
> Adrian
>
> --
>
> "Is there not promise of rain?" Ling Tan asked suddenly out
> of the darkness. There had been need of rain for many days.
> "Only a promise," Lao Er said.
> Pearl S. Buck - Dragon Seed
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2.6.16-rc1-mm5
2006-02-03 8:07 2.6.16-rc1-mm5 Andrew Morton
` (7 preceding siblings ...)
2006-02-03 21:25 ` 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken Adrian Bunk
@ 2006-02-04 7:59 ` Matthias Urlichs
2006-02-04 9:29 ` 2.6.16-rc1-mm5 Sam Ravnborg
9 siblings, 0 replies; 25+ messages in thread
From: Matthias Urlichs @ 2006-02-04 7:59 UTC (permalink / raw)
To: linux-kernel
Hi, Andrew Morton wrote:
> - If you hit a bug in -mm and it's not obvious which patch caused it, it
> is
> most valuable if you can perform a bisection search to identify which
> patch introduced the bug. Instructions for this process are at
>
> http://www.zip.com.au/~akpm/linux/patches/stuff/bisecting-mm-trees.txt
You can also use the mm->git tree (at .../linux/kernel/git/smurf/
/linux-trees.git) and use "git bisect".
It'll be a bit slower, but the upside is that it's able to descend into
the git trees which Andrew has imported into mm as monolithic patches.
--
Matthias Urlichs | {M:U} IT Design @ m-u-it.de | smurf@smurf.noris.de
Disclaimer: The quote was selected randomly. Really. | http://smurf.noris.de
- -
I do not fear computers. I fear the lack of them.
-- Isaac Asimov
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken
2006-02-03 21:25 ` 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken Adrian Bunk
2006-02-04 2:43 ` Jody McIntyre
@ 2006-02-04 9:08 ` Stefan Richter
2006-02-04 9:30 ` Stefan Richter
2006-02-04 9:31 ` Johannes Berg
2006-02-06 4:31 ` Jody McIntyre
2 siblings, 2 replies; 25+ messages in thread
From: Stefan Richter @ 2006-02-04 9:08 UTC (permalink / raw)
To: Adrian Bunk
Cc: Andrew Morton, bcollins, scjody, linux-kernel, linux1394-devel,
sam, Johannes Berg
Adrian Bunk wrote:
> ...
> OUI2C drivers/ieee1394/oui.c
> /bin/sh: drivers/ieee1394/oui2c.sh: No such file or directory
> make[3]: *** [drivers/ieee1394/oui.c] Error 127
>
> <-- snip -->
>
>
> The change that broke it is:
>
>
> quiet_cmd_oui2c = OUI2C $@
> - cmd_oui2c = $(CONFIG_SHELL) $(srctree)/$(src)/oui2c.sh < $< > $@
> + cmd_oui2c = $(CONFIG_SHELL) $(src)/oui2c.sh < $< > $@
How can this be reproduced? IOW which way of building the kernel is broken?
--
Stefan Richter
-=====-=-==- --=- --=--
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken
2006-02-04 2:43 ` Jody McIntyre
@ 2006-02-04 9:20 ` Sam Ravnborg
0 siblings, 0 replies; 25+ messages in thread
From: Sam Ravnborg @ 2006-02-04 9:20 UTC (permalink / raw)
To: Jody McIntyre
Cc: Adrian Bunk, Andrew Morton, bcollins, linux-kernel,
linux1394-devel
On Fri, Feb 03, 2006 at 09:43:54PM -0500, Jody McIntyre wrote:
> On Fri, Feb 03, 2006 at 10:25:07PM +0100, Adrian Bunk wrote:
> > ...
> > OUI2C drivers/ieee1394/oui.c
> > /bin/sh: drivers/ieee1394/oui2c.sh: No such file or directory
> > make[3]: *** [drivers/ieee1394/oui.c] Error 127
>
> I can't reproduce this. What steps are you using to build the kernel?
You need to use make O=some_dir to reproduce it.
like this:
# Create output dir and copy config
mkdir ~/o
cp ieee_config ~/o/.config
# Prepare kernel source
cd $KERNELSRC
make mrproper
# Build kernel
make O=~/o
Note - the breakage is only in -mm.
Sam
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2.6.16-rc1-mm5
2006-02-03 8:07 2.6.16-rc1-mm5 Andrew Morton
` (8 preceding siblings ...)
2006-02-04 7:59 ` 2.6.16-rc1-mm5 Matthias Urlichs
@ 2006-02-04 9:29 ` Sam Ravnborg
2006-02-04 9:36 ` 2.6.16-rc1-mm5 Andrew Morton
9 siblings, 1 reply; 25+ messages in thread
From: Sam Ravnborg @ 2006-02-04 9:29 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On Fri, Feb 03, 2006 at 12:07:04AM -0800, Andrew Morton wrote:
>
> Known problems:
>
> - Sam has added a new check in the kbuild tree. It detects multiple
> instances of EXPORT_SYMBOL(foo) across separate .o files.
>
> It catches a _lot_ of problems. You'll see something like this:
Sigh. I did a 'make allmodconfig' on x86_64 and found to my suprise only
a sinlge symbol being exported more than one time.
This is purely a consistency check introduced by commit:
http://www.kernel.org/git/?p=linux/kernel/git/sam/kbuild.git;a=commit;h=cd1f125e5808203d3bf58f1d04a9cbd33f60fdb6
I can rip it out again if the noise/value ratio is too high.
> Patches would be nice, but be warned that fixing these is not as trivial
> as one might think:
>
> - If one export is in generic code and the other is in arch code then
>
> - If you remove the export in generic code, you need to check all
> architectures for breakage.
We should IMO try to keep the exports in generic code.
The exports should go with the function definition - right after closing
'{'.
All other ways of exporting function is a call for inconsistency.
A gret deal of effort has been put into getting rid of ksym files
- good. But exports should not be scattered far away form the function
definition.
> - If you remove the export in arch code then you need to be sure
> that the generic .o file a) always compiles in the offending function
> and b) is always linked into vmlinux.
Placing the export just below the function definition should cover this
in 90% of the cases. The rest is macros..
>
> If possible, the best approach is to put the EXPORT_SYMBOL
> immediately after the symbol which is being exported. And if it's
> a function, pleeeze don't put a blank line between the end of the
> function and the export - I've no idea why people do that...
Agreed.
Sam
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken
2006-02-04 9:08 ` Stefan Richter
@ 2006-02-04 9:30 ` Stefan Richter
2006-02-04 9:31 ` Johannes Berg
1 sibling, 0 replies; 25+ messages in thread
From: Stefan Richter @ 2006-02-04 9:30 UTC (permalink / raw)
To: linux1394-devel
Cc: Adrian Bunk, Andrew Morton, bcollins, scjody, linux-kernel, sam,
Johannes Berg
(2nd attempt with corrected list of recipients)
I wrote:
> Adrian Bunk wrote:
>> ...
>> OUI2C drivers/ieee1394/oui.c
>> /bin/sh: drivers/ieee1394/oui2c.sh: No such file or directory
>> make[3]: *** [drivers/ieee1394/oui.c] Error 127
>>
>> <-- snip -->
>>
>>
>> The change that broke it is:
>>
>>
>> quiet_cmd_oui2c = OUI2C $@
>> - cmd_oui2c = $(CONFIG_SHELL) $(srctree)/$(src)/oui2c.sh < $< > $@
>> + cmd_oui2c = $(CONFIG_SHELL) $(src)/oui2c.sh < $< > $@
>
>
> How can this be reproduced? IOW which way of building the kernel is broken?
--
Stefan Richter
-=====-=-==- --=- --=--
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken
2006-02-04 9:08 ` Stefan Richter
2006-02-04 9:30 ` Stefan Richter
@ 2006-02-04 9:31 ` Johannes Berg
2006-02-04 9:58 ` Stefan Richter
1 sibling, 1 reply; 25+ messages in thread
From: Johannes Berg @ 2006-02-04 9:31 UTC (permalink / raw)
To: Stefan Richter
Cc: Adrian Bunk, Andrew Morton, bcollins, scjody, linux-kernel,
linux1394-devel, sam
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On Sat, 2006-02-04 at 10:08 +0100, Stefan Richter wrote:
> Adrian Bunk wrote:
> > ...
> > OUI2C drivers/ieee1394/oui.c
> > /bin/sh: drivers/ieee1394/oui2c.sh: No such file or directory
> > make[3]: *** [drivers/ieee1394/oui.c] Error 127
> >
> > <-- snip -->
> >
> >
> > The change that broke it is:
> >
> >
> > quiet_cmd_oui2c = OUI2C $@
> > - cmd_oui2c = $(CONFIG_SHELL) $(srctree)/$(src)/oui2c.sh < $< > $@
> > + cmd_oui2c = $(CONFIG_SHELL) $(src)/oui2c.sh < $< > $@
>
> How can this be reproduced? IOW which way of building the kernel is broken?
Looks like my mistake. I was pretty sure I tested the normal in-kernel
build way, sorry.
I did the change in order to build out of tree (with an absolute path as
a SUBDIRS value).
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2.6.16-rc1-mm5
2006-02-04 9:29 ` 2.6.16-rc1-mm5 Sam Ravnborg
@ 2006-02-04 9:36 ` Andrew Morton
0 siblings, 0 replies; 25+ messages in thread
From: Andrew Morton @ 2006-02-04 9:36 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: linux-kernel
Sam Ravnborg <sam@ravnborg.org> wrote:
>
> On Fri, Feb 03, 2006 at 12:07:04AM -0800, Andrew Morton wrote:
> >
> > Known problems:
> >
> > - Sam has added a new check in the kbuild tree. It detects multiple
> > instances of EXPORT_SYMBOL(foo) across separate .o files.
> >
> > It catches a _lot_ of problems. You'll see something like this:
>
> Sigh. I did a 'make allmodconfig' on x86_64 and found to my suprise only
> a sinlge symbol being exported more than one time.
>
> This is purely a consistency check introduced by commit:
> http://www.kernel.org/git/?p=linux/kernel/git/sam/kbuild.git;a=commit;h=cd1f125e5808203d3bf58f1d04a9cbd33f60fdb6
There were several tens on powerpc, sparc64, etc.
> I can rip it out again if the noise/value ratio is too high.
No, let's keep it. We're wasting memory on this stuff.
> We should IMO try to keep the exports in generic code.
Yes, I guess so. It gets tricky when you get onto things like the string
functions, most of which may be impemented in generic code or may be in
arch code, depending on __ARCH_HAVE_stuff.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken
2006-02-04 9:31 ` Johannes Berg
@ 2006-02-04 9:58 ` Stefan Richter
0 siblings, 0 replies; 25+ messages in thread
From: Stefan Richter @ 2006-02-04 9:58 UTC (permalink / raw)
To: Johannes Berg
Cc: Adrian Bunk, Andrew Morton, bcollins, scjody, linux-kernel,
linux1394-devel, sam
Johannes Berg wrote:
> On Sat, 2006-02-04 at 10:08 +0100, Stefan Richter wrote:
>>Adrian Bunk wrote:
>>>...
>>> OUI2C drivers/ieee1394/oui.c
>>>/bin/sh: drivers/ieee1394/oui2c.sh: No such file or directory
>>>make[3]: *** [drivers/ieee1394/oui.c] Error 127
...
>>How can this be reproduced? IOW which way of building the kernel is broken?
...
> I was pretty sure I tested the normal in-kernel build way,
When I confirmed your patch, I had successfully tested it on pristine
and on pre-built 2.6.15.1 and 2.6.16-rc1 trees when running make from
the trees' root directory, using the default shell of MDK 10.1.
But Adrian is right, "make O=/some/place/else" is broken. Which answers
my question above.
--
Stefan Richter
-=====-=-==- --=- --=--
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [-mm patch] net/ipv4/fib_rules.c: make struct fib_rules static again
2006-02-03 21:02 ` [-mm patch] net/ipv4/fib_rules.c: make struct fib_rules static again Adrian Bunk
@ 2006-02-04 23:51 ` David S. Miller
0 siblings, 0 replies; 25+ messages in thread
From: David S. Miller @ 2006-02-04 23:51 UTC (permalink / raw)
To: bunk; +Cc: akpm, robert.olsson, linux-kernel, netdev
From: Adrian Bunk <bunk@stusta.de>
Date: Fri, 3 Feb 2006 22:02:48 +0100
> struct fib_rules became global for no good reason.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Applied, thanks Adrian.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken
2006-02-03 21:25 ` 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken Adrian Bunk
2006-02-04 2:43 ` Jody McIntyre
2006-02-04 9:08 ` Stefan Richter
@ 2006-02-06 4:31 ` Jody McIntyre
2 siblings, 0 replies; 25+ messages in thread
From: Jody McIntyre @ 2006-02-06 4:31 UTC (permalink / raw)
To: Adrian Bunk
Cc: Andrew Morton, bcollins, linux-kernel, linux1394-devel, sam,
Johannes Berg
On Fri, Feb 03, 2006 at 10:25:07PM +0100, Adrian Bunk wrote:
> The change that broke it is:
>
>
> quiet_cmd_oui2c = OUI2C $@
> - cmd_oui2c = $(CONFIG_SHELL) $(srctree)/$(src)/oui2c.sh < $< > $@
> + cmd_oui2c = $(CONFIG_SHELL) $(src)/oui2c.sh < $< > $@
Reverted.
Johannes, please fix this such that builds with O= still work, or change
your out-of-tree Makefile so that this change is not needed.
Cheers,
Jody
>
>
> cu
> Adrian
>
> --
>
> "Is there not promise of rain?" Ling Tan asked suddenly out
> of the darkness. There had been need of rain for many days.
> "Only a promise," Lao Er said.
> Pearl S. Buck - Dragon Seed
>
--
^ permalink raw reply [flat|nested] 25+ messages in thread
* [-mm patch] Makefile: remove a tab from an empty line
@ 2006-02-08 12:07 Adrian Bunk
0 siblings, 0 replies; 25+ messages in thread
From: Adrian Bunk @ 2006-02-08 12:07 UTC (permalink / raw)
To: Andrew Morton; +Cc: sam, linux-kernel
Emacs warns if an otherwise empty line starts with a tab.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 3 Feb 2006
--- linux-2.6.16-rc1-mm5-full/Makefile.old 2006-02-03 12:46:09.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/Makefile 2006-02-03 12:46:31.000000000 +0100
@@ -1122,7 +1122,7 @@
.PHONY: modules_install
modules_install: _emodinst_ _emodinst_post
-
+
install-dir := $(if $(INSTALL_MOD_DIR),$(INSTALL_MOD_DIR),extra)
.PHONY: _emodinst_
_emodinst_:
^ permalink raw reply [flat|nested] 25+ messages in thread
* [-mm patch] Makefile: remove a tab from an empty line
@ 2006-02-14 14:58 Adrian Bunk
0 siblings, 0 replies; 25+ messages in thread
From: Adrian Bunk @ 2006-02-14 14:58 UTC (permalink / raw)
To: Andrew Morton; +Cc: sam, linux-kernel
Emacs warns if an otherwise empty line starts with a tab.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 8 Feb 2006
- 3 Feb 2006
--- linux-2.6.16-rc1-mm5-full/Makefile.old 2006-02-03 12:46:09.000000000 +0100
+++ linux-2.6.16-rc1-mm5-full/Makefile 2006-02-03 12:46:31.000000000 +0100
@@ -1122,7 +1122,7 @@
.PHONY: modules_install
modules_install: _emodinst_ _emodinst_post
-
+
install-dir := $(if $(INSTALL_MOD_DIR),$(INSTALL_MOD_DIR),extra)
.PHONY: _emodinst_
_emodinst_:
^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2006-02-14 14:58 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-03 8:07 2.6.16-rc1-mm5 Andrew Morton
2006-02-03 10:17 ` 2.6.16-rc1-mm5 Benoit Boissinot
2006-02-03 20:13 ` 2.6.16-rc1-mm5 Benoit Boissinot
2006-02-03 20:36 ` 2.6.16-rc1-mm5 Andrew Morton
2006-02-03 11:51 ` [-mm patch] Makefile: remove a tab from an empty line Adrian Bunk
2006-02-03 20:57 ` [-mm patch] kernel/time/timeofday.c: make struct ts_interval static Adrian Bunk
2006-02-03 21:50 ` john stultz
2006-02-03 20:59 ` [-mm patch] kernel/timer.c: make some variables static Adrian Bunk
2006-02-03 21:02 ` [-mm patch] net/ipv4/fib_rules.c: make struct fib_rules static again Adrian Bunk
2006-02-04 23:51 ` David S. Miller
2006-02-03 21:09 ` [-mm patch] make some "struct clocksource" static Adrian Bunk
2006-02-03 21:12 ` [-mm patch] arch/i386/kernel/cpu/: make tons of functions static Adrian Bunk
2006-02-03 21:25 ` 2.6.16-rc1-mm5: drivers/ieee1394/oui O=... builds broken Adrian Bunk
2006-02-04 2:43 ` Jody McIntyre
2006-02-04 9:20 ` Sam Ravnborg
2006-02-04 9:08 ` Stefan Richter
2006-02-04 9:30 ` Stefan Richter
2006-02-04 9:31 ` Johannes Berg
2006-02-04 9:58 ` Stefan Richter
2006-02-06 4:31 ` Jody McIntyre
2006-02-04 7:59 ` 2.6.16-rc1-mm5 Matthias Urlichs
2006-02-04 9:29 ` 2.6.16-rc1-mm5 Sam Ravnborg
2006-02-04 9:36 ` 2.6.16-rc1-mm5 Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2006-02-08 12:07 [-mm patch] Makefile: remove a tab from an empty line Adrian Bunk
2006-02-14 14:58 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox