public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: hawkes@sgi.com
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
	Jack Steiner <steiner@sgi.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] load_balance: "busiest CPU" -> "busier CPUs"
Date: Fri, 3 Feb 2006 18:36:52 -0800	[thread overview]
Message-ID: <20060203183651.A24554@unix-os.sc.intel.com> (raw)
In-Reply-To: <20060204003807.28210.77735.sendpatchset@tomahawk.engr.sgi.com>; from hawkes@sgi.com on Fri, Feb 03, 2006 at 04:38:07PM -0800

On Fri, Feb 03, 2006 at 04:38:07PM -0800, hawkes@sgi.com wrote:
> In these circumstances, an all-pinned "busiest CPU" will effectively
> disable load_balance balancing.

Solving all the load balancing issues that occur under all-pinned case is
tricy... For example, even with this patch, at a particular sched domain,
load balance might still be disabled for the cpus which belong to the same 
sched group as the all-pinned "busiest CPU"

> @@ -243,6 +243,8 @@ struct runqueue {
>  	int active_balance;
>  	int push_cpu;
>  
> +	int cpuid;			/* of this runqueue */
> +
>  	task_t *migration_thread;
>  	struct list_head migration_queue;

A simple change to find_busiest_queue() can avoid that addition to the
runqueue struct.

thanks,
suresh

  reply	other threads:[~2006-02-04  2:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-04  0:38 [PATCH] load_balance: "busiest CPU" -> "busier CPUs" hawkes
2006-02-04  2:36 ` Siddha, Suresh B [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-02-07  1:27 hawkes
2006-02-15  6:33 ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060203183651.A24554@unix-os.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=akpm@osdl.org \
    --cc=hawkes@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    --cc=steiner@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox