From: Johannes Stezenbach <js@linuxtv.org>
To: Michael Krufky <mkrufky@linuxtv.org>
Cc: Adrian Bunk <bunk@stusta.de>,
linux-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: [v4l-dvb-maintainer] [2.6 patch] drivers/media/dvb/frontends/mt312.c: possible cleanups
Date: Sun, 5 Feb 2006 14:29:30 +0100 [thread overview]
Message-ID: <20060205132930.GA6221@linuxtv.org> (raw)
In-Reply-To: <43E5A23D.8080107@linuxtv.org>
On Sun, Feb 05, 2006, Michael Krufky wrote:
> Adrian Bunk wrote:
> >+ if (state->id == ID_VP310){
lacks a space
> >-EXPORT_SYMBOL(mt312_attach);
> >-EXPORT_SYMBOL(vp310_attach);
> >+EXPORT_SYMBOL(vp310_mt312_attach);
>
> ^^^ I think vp310_mt312_attach is starting to get long, maybe even ugly.
> Isn't mt312_attach enough, considering that it is the name of the
> module? I think just mt312_attach would be nicer, unless someone thinks
> otherwise?
...
> >- if ((fc->fe = vp310_attach(&skystar23_samsung_tbdu18132_config,
> >&fc->i2c_adap)) != NULL) {
> >+ if ((fc->fe =
> >vp310_mt312_attach(&skystar23_samsung_tbdu18132_config, &fc->i2c_adap)) !=
> >NULL) {
mt312_attach() isn't used by any driver, so it looks like a bad choice
for a name. IMHO vp310_mt312_attach() is fine.
Johannes
next prev parent reply other threads:[~2006-02-05 13:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-04 23:37 [2.6 patch] drivers/media/dvb/frontends/mt312.c: possible cleanups Adrian Bunk
2006-02-05 6:59 ` [v4l-dvb-maintainer] " Michael Krufky
2006-02-05 13:29 ` Johannes Stezenbach [this message]
2006-02-07 22:38 ` [2.6 patch] drivers/media/dvb/frontends/mt312.c: cleanups Adrian Bunk
2006-02-10 4:45 ` Michael Krufky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060205132930.GA6221@linuxtv.org \
--to=js@linuxtv.org \
--cc=bunk@stusta.de \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox