From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Michael E Brown <michael_e_brown@Dell.com>
Cc: Andrew Morton <akpm@osdl.org>,
matt_domsch@Dell.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RESEND] Add Dell laptop backlight brightness display
Date: Tue, 7 Feb 2006 04:09:35 +0000 [thread overview]
Message-ID: <20060207040935.GA25853@srcf.ucam.org> (raw)
In-Reply-To: <1139283796.28567.179.camel@soltek.michaels-house.net>
On Mon, Feb 06, 2006 at 09:43:16PM -0600, Michael E Brown wrote:
> I would _strongly_ suggest that this patch _not_ go in. This driver
> uses hardcoded values that are subject to change without notice. It is
> perfectly legitimate for future versions of Dell BIOS to interpret pokes
> to cmos location 0x99 as the command to format your hard drive.
I managed to send the wrong patch - the Dell one only reads from nvram.
If nvram reads are likely to reformat your hard drive, I think Dell
needs to reconsider its BIOS design :)
More seriously, a quick scan of libsmbios hasn't revealed any method for
obtaining the screen brightness. It's possible that I'm blind (I'm
certainly slightly drunk), but can you give a pointer to the correct
mechanism for making this call?
Thanks,
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2006-02-07 4:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-07 3:43 [PATCH] [RESEND] Add Dell laptop backlight brightness display Michael E Brown
2006-02-07 4:09 ` Matthew Garrett [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-02-20 16:45 Michael_E_Brown
2006-02-20 16:53 ` Pavel Machek
2006-02-23 5:17 ` Michael E Brown
2006-02-07 17:23 Michael_E_Brown
2006-02-07 16:34 Michael_E_Brown
2006-02-07 17:20 ` Matthew Garrett
2006-02-12 17:26 ` Pavel Machek
2006-02-06 19:15 [PATCH] Make DMI code store chassis type Matthew Garrett
2006-02-06 19:18 ` [PATCH] Add HP laptop backlight brightness display Matthew Garrett
2006-02-06 19:19 ` [PATCH] Add Dell " Matthew Garrett
2006-02-07 0:37 ` [PATCH] [RESEND] " Matthew Garrett
2006-02-07 3:37 ` Dmitry Torokhov
2006-02-07 12:32 ` Matthew Garrett
2006-02-07 13:06 ` Richard Purdie
2006-02-07 13:23 ` Matthew Garrett
2006-02-07 13:37 ` Richard Purdie
2006-02-07 13:55 ` Matthew Garrett
2006-02-07 14:54 ` Richard Purdie
2006-02-08 9:06 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060207040935.GA25853@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt_domsch@Dell.com \
--cc=michael_e_brown@Dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox