From: Russell King <rmk+lkml@arm.linux.org.uk>
To: stephen@streetfiresound.com
Cc: greg@kroah.com, linux-kernel@vger.kernel.org, dvrabel@arcom.com,
david-b@pacbell.net
Subject: Re: [PATCH] spi: Fix modular master driver remove and device suspend/remove
Date: Tue, 7 Feb 2006 08:03:51 +0000 [thread overview]
Message-ID: <20060207080351.GA3588@flint.arm.linux.org.uk> (raw)
In-Reply-To: <43e80e2b.EZgObIkBxyg9Mb6O%stephen@streetfiresound.com>
On Mon, Feb 06, 2006 at 07:04:11PM -0800, stephen@streetfiresound.com wrote:
> --- linux-2.6.16-rc2/drivers/spi/spi.c 2006-02-06 18:39:31.746537258 -0800
> +++ linux-spi/drivers/spi/spi.c 2006-02-06 18:39:45.353334421 -0800
> @@ -90,7 +90,7 @@ static int spi_suspend(struct device *de
> int value;
> struct spi_driver *drv = to_spi_driver(dev->driver);
>
> - if (!drv->suspend)
> + if (!drv || !drv->suspend)
Shouldn't this be dev->driver ? If dev->driver is NULL, drv may be
non-NULL due to an offset in the structure.
> @@ -105,7 +105,7 @@ static int spi_resume(struct device *dev
> int value;
> struct spi_driver *drv = to_spi_driver(dev->driver);
>
> - if (!drv->resume)
> + if (!drv || !drv->resume)
Ditto.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-02-07 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-07 3:04 [PATCH] spi: Fix modular master driver remove and device suspend/remove stephen
2006-02-07 8:03 ` Russell King [this message]
2006-02-07 21:35 ` Stephen Street
2006-02-07 21:56 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060207080351.GA3588@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=david-b@pacbell.net \
--cc=dvrabel@arcom.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stephen@streetfiresound.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox