Re: [PATCH] x86-64: improve the format of stack dumps

Luben Tuikov
2006-02-07T19:17:21Z

--- Andi Kleen <ak@suse.de> wrote:
> On Tuesday 07 February 2006 06:13, Luben Tuikov wrote:
> > Improve the format of stack dumps for x86-64.
> > * Single column of stack entries. (similar to other arches)
>
> I don't like that part as I wrote earlier.It's a waste of precious
> screen space, no matter how often you retransmit the patch. The old
> format had a chance to even fit on a 80x25 screen, with your new one
> it is extremly unlikely.
>
> Overall you're making less information available in a common case
> for cosmetics.

And as I wrote earlier, this patch doesn't only improve output,
it also _reuses_ code, i.e. __print_symbol() which your code recreates
in printk_address(). Now printk_address() reuses the common __print_symbol().

One very important thing this patch also does is that it prints the offsets
in hexadecimal, as opposed to decimal. I.e. from

0xNNNNNNNN+DDD to 0xNNNNNNNNN+0xTTT/0xWWW

As to "less space", this patch prints _identical_ information as the code
before it, as I'm sure you can see by reading the patch itself.

Thanks,
Luben