From: Andi Kleen <ak@suse.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Cleanup possibility in asm-i386/string.h
Date: Tue, 7 Feb 2006 12:15:46 +0100 [thread overview]
Message-ID: <200602071215.46885.ak@suse.de> (raw)
Adrian,
If you feel the need to remove some more code: Now that gcc 2.95 isn't supported
anymore there isn't really a need to keep the handwritten inline string functions
in asm-i386/string.h around. Just declaring them as normal externs will cause
gcc to use its builtin expansions, which are typically better than these old inline
functions with inline assembly.
For out of line the C versions in lib/string.c can be used (by not setting __ARCH_*)
x86-64 did it like this forever and I guess it would be valuable cleanup for i386 too.
-Andi
next reply other threads:[~2006-02-07 11:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-07 11:15 Andi Kleen [this message]
2006-02-07 12:00 ` Cleanup possibility in asm-i386/string.h Roman Zippel
2006-02-07 12:08 ` Andi Kleen
2006-02-07 12:39 ` Roman Zippel
2006-02-10 0:05 ` Adrian Bunk
2006-02-10 0:23 ` Andi Kleen
2006-02-10 1:00 ` Kyle Moffett
2006-02-10 13:02 ` Roman Zippel
2006-02-10 13:49 ` Andi Kleen
2006-02-10 14:46 ` Roman Zippel
2006-02-10 15:02 ` Andi Kleen
2006-02-10 0:53 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602071215.46885.ak@suse.de \
--to=ak@suse.de \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox