From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Paul Jackson <pj@sgi.com>, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: OOM behavior in constrained memory situations
Date: Tue, 7 Feb 2006 19:31:09 +0100 [thread overview]
Message-ID: <200602071931.10230.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0602071018050.25222@schroedinger.engr.sgi.com>
On Tuesday 07 February 2006 19:19, Christoph Lameter wrote:
> @@ -1261,7 +1261,7 @@ struct page *alloc_pages_current(gfp_t g
> cpuset_update_task_memory_state();
> if (!pol || in_interrupt())
> pol = &default_policy;
> - gfp |= pol->gfp_flags;
> + gfp |= (pol->gfp_flags_high << 16);
Why don't you put it into zonelist_policy and pass a pointer to gfp
and then only do it for MPOL_BIND? The code should be similar because
it should be inline anyways (perhaps add a force_inline to be sure)
-Andi
next prev parent reply other threads:[~2006-02-07 18:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-06 20:59 OOM behavior in constrained memory situations Christoph Lameter
2006-02-06 21:10 ` Andrew Morton
2006-02-06 21:22 ` Andi Kleen
2006-02-06 22:16 ` Christoph Lameter
2006-02-06 22:25 ` Andi Kleen
2006-02-06 22:30 ` Andrew Morton
2006-02-07 0:03 ` Christoph Lameter
2006-02-09 23:08 ` David Gibson
2006-02-06 22:11 ` Christoph Lameter
2006-02-06 22:26 ` Andrew Morton
2006-02-06 22:59 ` Paul Jackson
2006-02-07 0:39 ` Christoph Lameter
2006-02-07 1:55 ` Christoph Lameter
2006-02-07 9:23 ` Andi Kleen
2006-02-07 17:29 ` Christoph Lameter
2006-02-07 17:45 ` Andi Kleen
2006-02-07 17:51 ` Christoph Lameter
2006-02-07 17:58 ` Andi Kleen
2006-02-07 18:10 ` Christoph Lameter
2006-02-07 18:19 ` Christoph Lameter
2006-02-07 18:31 ` Andi Kleen [this message]
2006-02-07 19:00 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602071931.10230.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox