public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Nigel Cunningham <ncunningham@cyclades.com>
Cc: Linux PM <linux-pm@osdl.org>,
	linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Complain if driver reenables interrupts during drivers_[suspend|resume] & re-disable
Date: Tue, 7 Feb 2006 23:59:11 +0000	[thread overview]
Message-ID: <20060207235911.GB26558@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200602071906.55281.ncunningham@cyclades.com>

On Tue, Feb 07, 2006 at 07:06:48PM +1000, Nigel Cunningham wrote:
> This patch is designed to help with diagnosing and fixing the cause of
> problems in suspending/resuming, due to drivers wrongly re-enabling
> interrupts in their .suspend or .resume methods. 

Sorry, aren't interrupts enabled at this point anyway?  They are if
you issue a suspend to RAM via sysfs, eg:

state_store->enter_state->suspend_prepare->device_suspend->suspend_device

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

  reply	other threads:[~2006-02-07 23:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-07  9:06 [PATCH] Complain if driver reenables interrupts during drivers_[suspend|resume] & re-disable Nigel Cunningham
2006-02-07 23:59 ` Russell King [this message]
2006-02-08  3:47 ` Benjamin Herrenschmidt
2006-02-08  5:40 ` Dmitry Torokhov
2006-02-08  6:46   ` Rafael J. Wysocki
2006-02-08 23:58   ` Nigel Cunningham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060207235911.GB26558@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@osdl.org \
    --cc=ncunningham@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox