From: Jens Axboe <axboe@suse.de>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: kill not-so-popular simple flag testing macros
Date: Wed, 8 Feb 2006 10:04:57 +0100 [thread overview]
Message-ID: <20060208090457.GF4338@suse.de> (raw)
In-Reply-To: <20060208085728.GA21065@htj.dyndns.org>
On Wed, Feb 08 2006, Tejun Heo wrote:
> This patch kills the following request flag testing macros.
>
> blk_noretry_request()
> blk_rq_started()
> blk_pm_suspend_request()
> blk_pm_resume_request()
> blk_sorted_rq()
> blk_barrier_rq()
> blk_fua_rq()
>
> All above macros test for single request flag and not used widely and
> seem to contribute more to obscurity than readability.
Agreed, I've queued it up post-2.6.16
--
Jens Axboe
next prev parent reply other threads:[~2006-02-08 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 8:57 [PATCH] block: kill not-so-popular simple flag testing macros Tejun Heo
2006-02-08 9:04 ` Jens Axboe [this message]
2006-02-09 18:42 ` Jeff Garzik
2006-02-10 0:21 ` Tejun Heo
2006-02-10 1:19 ` Jeff Garzik
2006-02-10 7:25 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060208090457.GF4338@suse.de \
--to=axboe@suse.de \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox